On 13/09/2017 16:57, Sean Young wrote:
On Sep 13, 2017 at 16:03, Mason wrote:
Changes from v1 to v2:
o Rebase driver on top of linuxtv/master
o Use ir_nec_bytes_to_scancode() in tango_ir_handle_nec()
o Use devm_rc_allocate_device() in tango_ir_probe()
o Use Use devm_rc_register_device() in ta
Hi,
On Wed, Sep 13, 2017 at 04:03:43PM +0200, Mason wrote:
> On 12/09/2017 20:19, Sean Young wrote:
>
> > It looks great, thanks! I have made some minor points below.
>
> Thanks for having reviewed the driver! :-)
>
> I have now fixed all the points you mentioned.
>
> Changes from v1 to v2:
>
On 12/09/2017 20:19, Sean Young wrote:
It looks great, thanks! I have made some minor points below.
Thanks for having reviewed the driver! :-)
I have now fixed all the points you mentioned.
Changes from v1 to v2:
o Rebase driver on top of linuxtv/master
o Use ir_nec_bytes_to_scancode() in t
On Tue, Sep 12, 2017 at 05:56:11PM +0200, Mason wrote:
> On 11/09/2017 23:12, Sean Young wrote:
>
> > On Sep 11, 2017 at 04:37, Mason wrote:
> >
> > > I'm confused. Does this mean a keymap is mandatory?
> > > I thought it was possible to handle the "scancode to keycode"
> > > step in user-space?
On 11/09/2017 23:12, Sean Young wrote:
On Sep 11, 2017 at 04:37, Mason wrote:
I'm confused. Does this mean a keymap is mandatory?
I thought it was possible to handle the "scancode to keycode"
step in user-space?
The handling could be better here, but for nec repeats, yes a matching
keycode i
Hi Mason,
On Mon, Sep 11, 2017 at 04:37:42PM +0200, Mason wrote:
> Hello Sean,
>
> After a long hiatus, I can now work again on the IR driver support
> for tango platforms. I'm still using this driver:
>
> https://github.com/mansr/linux-tangox/blob/master/drivers/media/rc
Hello Sean,
After a long hiatus, I can now work again on the IR driver support
for tango platforms. I'm still using this driver:
https://github.com/mansr/linux-tangox/blob/master/drivers/media/rc/tangox-ir.c
There are two nits I'd like to discuss.
A) When I hold a key on the RC, i
