Re: About the radio-si470x driver for I2C interface

2009-04-13 Thread Joonyoung Shim
On 4/14/2009 3:35 AM, Tobias Lorenz wrote: > Hi Joonyoung, > >> I have some problem. There is codes for usb in radio-si470x-common.c file. > >> Hrm, if it cannot be removed, maybe it seems to seperate using ifdef. > >> What do you think about this? > > I moved some more functions from radio-si4

Re: About the radio-si470x driver for I2C interface

2009-04-13 Thread Hans Verkuil
On Monday 13 April 2009 03:14:13 Alexey Klimov wrote: > Hello, Tobias > > On Mon, Apr 13, 2009 at 12:56 AM, Tobias Lorenz wrote: > > Hi Joonyoung, > > > > Hi Alexey, > > > > I've split the driver into a couple of segments: > > > > - radio-si470x-common.c is for common functions > > > > - radio-si

Re: About the radio-si470x driver for I2C interface

2009-04-13 Thread Joonyoung Shim
On 4/13/2009 7:31 PM, Joonyoung Shim wrote: >> I'm not sure about the consequences in case of renaming the radio-si470x >> module. But it would be consequent to add the appendix -usb and -i2c to >> the current name. >> >> I applied the patch as follows: > > Okay, your patch is better. > Thanks. >

Re: About the radio-si470x driver for I2C interface

2009-04-13 Thread Joonyoung Shim
> I'm not sure about the consequences in case of renaming the radio-si470x > module. But it would be consequent to add the appendix -usb and -i2c to > the current name. > > I applied the patch as follows: Okay, your patch is better. Thanks. I will post the i2c part soon after testing. -- To unsu

Re: About the radio-si470x driver for I2C interface

2009-04-12 Thread Joonyoung Shim
On 4/13/2009 10:46 AM, Joonyoung Shim wrote: > On 4/13/2009 5:56 AM, Tobias Lorenz wrote: >> Hi Joonyoung, >> >> Hi Alexey, >> >> I've split the driver into a couple of segments: >> >> - radio-si470x-common.c is for common functions >> >> - radio-si470x-usb.c are the usb support functions >> >> - r

Re: About the radio-si470x driver for I2C interface

2009-04-12 Thread Joonyoung Shim
On 4/13/2009 5:56 AM, Tobias Lorenz wrote: > Hi Joonyoung, > > Hi Alexey, > > I've split the driver into a couple of segments: > > - radio-si470x-common.c is for common functions > > - radio-si470x-usb.c are the usb support functions > > - radio-si470x-i2c.c is an untested prototyped file for

Re: About the radio-si470x driver for I2C interface

2009-04-12 Thread Alexey Klimov
Hello, Tobias On Mon, Apr 13, 2009 at 12:56 AM, Tobias Lorenz wrote: > Hi Joonyoung, > > Hi Alexey, > > I've split the driver into a couple of segments: > > - radio-si470x-common.c is for common functions > > - radio-si470x-usb.c are the usb support functions > > - radio-si470x-i2c.c is an untest

Re: About the radio-si470x driver for I2C interface

2009-04-01 Thread Joonyoung Shim
> Hello > > On Tue, Mar 10, 2009 at 3:20 AM, Mauro Carvalho Chehab > wrote: >> On Mon, 9 Mar 2009 23:33:38 +0100 >> Tobias Lorenz wrote: >> >>> Hi, >>> The proper way is to break radio-si470x into two parts: - A i2c adapter driver (similar to what we have on cx88-i2c, for

Re: About the radio-si470x driver for I2C interface

2009-03-31 Thread Alexey Klimov
Hello On Tue, Mar 10, 2009 at 3:20 AM, Mauro Carvalho Chehab wrote: > On Mon, 9 Mar 2009 23:33:38 +0100 > Tobias Lorenz wrote: > >> Hi, >> >> > The proper way is to break radio-si470x into two parts: >> > >> >     - A i2c adapter driver (similar to what we have on cx88-i2c, for >> >       exampl

Re: About the radio-si470x driver for I2C interface

2009-03-09 Thread Mauro Carvalho Chehab
On Mon, 9 Mar 2009 23:33:38 +0100 Tobias Lorenz wrote: > Hi, > > > The proper way is to break radio-si470x into two parts: > > > > - A i2c adapter driver (similar to what we have on cx88-i2c, for > > example, plus the radio part of cx88-video); > > - A radio driver (similar to tea

Re: About the radio-si470x driver for I2C interface

2009-03-06 Thread Mauro Carvalho Chehab
On Fri, 6 Mar 2009 12:13:05 +0900 Joonyoung Shim wrote: > Hi all, > > I have worked with Silicon Labs Si4709 chip using the I2C interface. > There is the radio-si470x driver in linux-kernel, but it uses usb interface. > > First, i made a new file based on radio-si470x.c in driver/media/radio/ f

About the radio-si470x driver for I2C interface

2009-03-05 Thread Joonyoung Shim
Hi all, I have worked with Silicon Labs Si4709 chip using the I2C interface. There is the radio-si470x driver in linux-kernel, but it uses usb interface. First, i made a new file based on radio-si470x.c in driver/media/radio/ for si4709 i2c driver and modified it to use i2c interface instead of u