Re: [v3][PATCH 4/5] media: ov2640: add a master clock for sensor

2014-12-11 Thread Laurent Pinchart
Hi Josh, Thank you for the patch. On Thursday 11 December 2014 15:35:38 Josh Wu wrote: > The master clock (xvclk) is mandatory. It's a common clock framework clock. > It can make sensor output a pixel clock to the camera interface. > > Cc: devicet...@vger.kernel.org > Signed-off-by: Josh Wu Ac

[v3][PATCH 4/5] media: ov2640: add a master clock for sensor

2014-12-10 Thread Josh Wu
The master clock (xvclk) is mandatory. It's a common clock framework clock. It can make sensor output a pixel clock to the camera interface. Cc: devicet...@vger.kernel.org Signed-off-by: Josh Wu --- v2 -> v3: 1. should return PTR_ERR(). v1 -> v2: 1. change the clock's name. 2. Make the clo