Hi Todor,
On Thu, Mar 29, 2018 at 10:50:10AM +0300, Todor Tomov wrote:
> Hi Jacopo,
>
>
> >
> > With the above nits clarified, and as you addressed my v1 comments:
> >
> > Reviewed-by: Jacopo Mondi
>
> Would you like to see the corrections or I can add the tag before sending
> them?
>
I don't h
Hi Todor,
On Thu, Mar 29, 2018 at 01:09:18PM +0300, Todor Tomov wrote:
> > There's another change needed, too, which is not using of_match_ptr
> > macro, but instead assigning the of_match_table unconditionally.
>
> In that case the MODULE_DEVICE_TABLE(i2c, ...) is again not needed?
> And matchin
Hi Sakari
On 29.03.2018 11:29, Sakari Ailus wrote:
> Hi Todor and Jacopo,
>
> On Thu, Mar 29, 2018 at 10:50:10AM +0300, Todor Tomov wrote:
> ...
+static const struct of_device_id ov7251_of_match[] = {
+ { .compatible = "ovti,ov7251" },
+ { /* sentinel */ }
+};
+MODULE_D
Hi Todor and Jacopo,
On Thu, Mar 29, 2018 at 10:50:10AM +0300, Todor Tomov wrote:
...
> >> +static const struct of_device_id ov7251_of_match[] = {
> >> + { .compatible = "ovti,ov7251" },
> >> + { /* sentinel */ }
> >> +};
> >> +MODULE_DEVICE_TABLE(of, ov7251_of_match);
> >> +
> >> +static struct
Hi Jacopo,
Thank you for your prompt review.
On 23.03.2018 15:40, jacopo mondi wrote:
> Hi Todor,
>thanks for the patch.
>
> When running checkpatch --strict I see a few warning you can easily
> close (braces indentation mostly, and one additional empty line at
> line 1048).
Thank you for p
Hi Todor,
thanks for the patch.
When running checkpatch --strict I see a few warning you can easily
close (braces indentation mostly, and one additional empty line at
line 1048).
A few more nits below.
On Fri, Mar 23, 2018 at 12:14:20PM +0800, Todor Tomov wrote:
> The ov7251 sensor is a 1/7.5
