On Wed, Sep 14, 2011 at 03:28, Scott Jiang wrote:
>>> +#ifdef CONFIG_VIDEO_ADV_DEBUG
>>
>> just use DEBUG ?
>>
> no, v4l2 use CONFIG_VIDEO_ADV_DEBUG
ok, i was thinking this was something we added (since we have "ADVxxx" parts)
>>> + v4l_info(client, "chip found @ 0x%02x (%s)\n",
>>> +
>
>> +#ifdef CONFIG_VIDEO_ADV_DEBUG
>
> just use DEBUG ?
>
no, v4l2 use CONFIG_VIDEO_ADV_DEBUG
>> + v4l_info(client, "chip found @ 0x%02x (%s)\n",
>> + client->addr << 1, client->adapter->name);
>
> is that "<< 1" correct ? i dont think so ...
every driver under media
On Tue, Sep 13, 2011 at 14:34, Scott Jiang wrote:
> --- a/drivers/media/video/Makefile
> +++ b/drivers/media/video/Makefile
>
> +obj-$(CONFIG_VIDEO_VS6624) += vs6624.o
> obj-$(CONFIG_VIDEO_VPX3220) += vpx3220.o
should be after vpx, not before ?
> --- /dev/null
> +++ b/drivers/media/video/vs6624