Re: [patch v2] video/saa7134: change dprintk() to i2cdprintk()

2010-05-24 Thread Jean Delvare
Hi Dan, On Mon, 24 May 2010 17:59:36 +0200, Dan Carpenter wrote: > The problem is that dprintk() dereferences "dev" which is null here. > The i2cdprintk() uses "ir" so that's OK. > > Also removed a duplicated break statement. Mixing two unrelated fixes in the same patch is a bad idea. Here, the

[patch v2] video/saa7134: change dprintk() to i2cdprintk()

2010-05-24 Thread Dan Carpenter
The problem is that dprintk() dereferences "dev" which is null here. The i2cdprintk() uses "ir" so that's OK. Also removed a duplicated break statement. Signed-off-by: Dan Carpenter --- v2: Jean Delvare suggested that I use i2cdprintk() instead of modifying dprintk(). diff --git a/drivers/media