Re: [patch review 6/6] radio-mr800: redesign radio->users counter

2009-08-10 Thread David Ellingsworth
On Sat, Aug 8, 2009 at 1:46 PM, Alexey Klimov wrote: > Redesign radio->users counter. Don't allow more that 5 users on radio in > usb_amradio_open() and don't stop radio device if other userspace > application uses it in usb_amradio_close(). > > Signed-off-by: Alexey Klimov > > -- > diff -r c2dd9d

Re: [patch review 6/6] radio-mr800: redesign radio->users counter

2009-08-09 Thread Alexey Klimov
On Sun, Aug 9, 2009 at 12:19 PM, Hans Verkuil wrote: > On Saturday 08 August 2009 22:16:28 wk wrote: >> Alexey Klimov schrieb: >> > On Sat, Aug 8, 2009 at 10:01 PM, Trent Piepho wrote: >> > >> >> On Sat, 8 Aug 2009, Alexey Klimov wrote: >> >> >> >>> Redesign radio->users counter. Don't allow more t

Re: [patch review 6/6] radio-mr800: redesign radio->users counter

2009-08-09 Thread Hans Verkuil
On Saturday 08 August 2009 22:16:28 wk wrote: > Alexey Klimov schrieb: > > On Sat, Aug 8, 2009 at 10:01 PM, Trent Piepho wrote: > > > >> On Sat, 8 Aug 2009, Alexey Klimov wrote: > >> > >>> Redesign radio->users counter. Don't allow more that 5 users on radio in > >>> > >> Why? > >>

Re: [patch review 6/6] radio-mr800: redesign radio->users counter

2009-08-08 Thread wk
Alexey Klimov schrieb: On Sat, Aug 8, 2009 at 10:01 PM, Trent Piepho wrote: On Sat, 8 Aug 2009, Alexey Klimov wrote: Redesign radio->users counter. Don't allow more that 5 users on radio in Why? Well, v4l2 specs says that multiple opens are optional. Honestly, i think tha

Re: [patch review 6/6] radio-mr800: redesign radio->users counter

2009-08-08 Thread Alexey Klimov
On Sat, Aug 8, 2009 at 10:01 PM, Trent Piepho wrote: > On Sat, 8 Aug 2009, Alexey Klimov wrote: >> Redesign radio->users counter. Don't allow more that 5 users on radio in > > Why? Well, v4l2 specs says that multiple opens are optional. Honestly, i think that five userspace applications open /dev/

Re: [patch review 6/6] radio-mr800: redesign radio->users counter

2009-08-08 Thread Trent Piepho
On Sat, 8 Aug 2009, Alexey Klimov wrote: > Redesign radio->users counter. Don't allow more that 5 users on radio in Why? -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/m

[patch review 6/6] radio-mr800: redesign radio->users counter

2009-08-08 Thread Alexey Klimov
Redesign radio->users counter. Don't allow more that 5 users on radio in usb_amradio_open() and don't stop radio device if other userspace application uses it in usb_amradio_close(). Signed-off-by: Alexey Klimov -- diff -r c2dd9da28106 linux/drivers/media/radio/radio-mr800.c --- a/linux/drivers/