Re: [patch -next] V4L: ivtv: remove unneeded NULL checks

2010-07-23 Thread Dan Carpenter
On Fri, Jul 23, 2010 at 07:46:47AM -0400, Andy Walls wrote: > On Fri, 2010-07-23 at 12:12 +0200, Dan Carpenter wrote: > > In ivtvfb_callback_cleanup() we dereference "itv" before checking that > > it's NULL. "itv" is assigned with container_of() which basically never > > returns a NULL pointer so

Re: [patch -next] V4L: ivtv: remove unneeded NULL checks

2010-07-23 Thread Andy Walls
On Fri, 2010-07-23 at 12:12 +0200, Dan Carpenter wrote: > In ivtvfb_callback_cleanup() we dereference "itv" before checking that > it's NULL. "itv" is assigned with container_of() which basically never > returns a NULL pointer so the check is pointless. I removed it, along > with a similar check

[patch -next] V4L: ivtv: remove unneeded NULL checks

2010-07-23 Thread Dan Carpenter
In ivtvfb_callback_cleanup() we dereference "itv" before checking that it's NULL. "itv" is assigned with container_of() which basically never returns a NULL pointer so the check is pointless. I removed it, along with a similar check in ivtvfb_callback_init(). I considered adding a check for v4l2