Re: [patch] IR: ene_ir: problems in unwinding on probe

2010-08-12 Thread Maxim Levitsky
On Thu, 2010-08-12 at 18:19 +0200, Dan Carpenter wrote: > On Thu, Aug 12, 2010 at 05:35:04PM +0300, Maxim Levitsky wrote: > > On Thu, 2010-08-12 at 09:46 +0200, Dan Carpenter wrote: > > > There were a couple issues here. If the allocation failed for "dev" > > > then it would lead to a NULL deref

Re: [patch] IR: ene_ir: problems in unwinding on probe

2010-08-12 Thread Dan Carpenter
On Thu, Aug 12, 2010 at 05:35:04PM +0300, Maxim Levitsky wrote: > On Thu, 2010-08-12 at 09:46 +0200, Dan Carpenter wrote: > > There were a couple issues here. If the allocation failed for "dev" > > then it would lead to a NULL dereference. If request_irq() or > > request_region() failed it would

Re: [patch] IR: ene_ir: problems in unwinding on probe

2010-08-12 Thread Maxim Levitsky
On Thu, 2010-08-12 at 09:46 +0200, Dan Carpenter wrote: > There were a couple issues here. If the allocation failed for "dev" > then it would lead to a NULL dereference. If request_irq() or > request_region() failed it would release the irq and the region even > though they were not successfully

[patch] IR: ene_ir: problems in unwinding on probe

2010-08-12 Thread Dan Carpenter
There were a couple issues here. If the allocation failed for "dev" then it would lead to a NULL dereference. If request_irq() or request_region() failed it would release the irq and the region even though they were not successfully aquired. Signed-off-by: Dan Carpenter diff --git a/drivers/me