Re: [media] winbond-cir: Move assignments for three variables in wbcir_shutdown()

>> Move the setting for the local variables "mask", "match" and "rc6_csl" >> behind the source code for a condition check by this function >> at the beginning. > > Again, I can't see what the point is? * How do you think about to set these variables only after the initial check succeded? * Do

Re: [media] winbond-cir: Move assignments for three variables in wbcir_shutdown()

Move the setting for the local variables "mask", "match" and "rc6_csl" behind the source code for a condition check by this function at the beginning. >>> >>> Again, I can't see what the point is? >> >> * How do you think about to set these variables only after the initial >> check s

Re: [media] winbond-cir: Move assignments for three variables in wbcir_shutdown()

October 19, 2016 3:38 PM, "SF Markus Elfring" wrote: >>> Move the setting for the local variables "mask", "match" and "rc6_csl" >>> behind the source code for a condition check by this function >>> at the beginning. >> >> Again, I can't see what the point is? > > * How do you think about to set

Re: [PATCH 3/5] [media] winbond-cir: Move assignments for three variables in wbcir_shutdown()

October 14, 2016 1:43 PM, "SF Markus Elfring" wrote: > From: Markus Elfring > Date: Fri, 14 Oct 2016 10:40:12 +0200 > > Move the setting for the local variables "mask", "match" and "rc6_csl" > behind the source code for a condition check by this function > at the beginning. Again, I can't see

[PATCH 3/5] [media] winbond-cir: Move assignments for three variables in wbcir_shutdown()

From: Markus Elfring Date: Fri, 14 Oct 2016 10:40:12 +0200 Move the setting for the local variables "mask", "match" and "rc6_csl" behind the source code for a condition check by this function at the beginning. Signed-off-by: Markus Elfring --- drivers/media/rc/winbond-cir.c | 8 1 fil