Re: [media] duplicate code in media drivers

2018-05-22 Thread Gustavo A. R. Silva
On 05/21/2018 03:44 PM, Devin Heitmueller wrote: diff -u -p drivers/media/dvb-frontends/au8522_decoder.c /tmp/nothing/media/dvb-frontends/au8522_decoder.c --- drivers/media/dvb-frontends/au8522_decoder.c +++ /tmp/nothing/media/dvb-frontends/au8522_decoder.c @@ -280,14 +280,9 @@ static void set

Re: [media] duplicate code in media drivers

2018-05-22 Thread Gustavo A. R. Silva
Mauro, I already sent some patches based on your comments. Thanks! -- Gustavo On 05/21/2018 03:14 PM, Mauro Carvalho Chehab wrote: Em Mon, 21 May 2018 14:39:51 -0500 "Gustavo A. R. Silva" escreveu: Hi Mauro, I found some duplicate code with the help of Coccinelle and Coverity. Notice that

Re: [media] duplicate code in media drivers

2018-05-21 Thread Devin Heitmueller
>> diff -u -p drivers/media/dvb-frontends/au8522_decoder.c >> /tmp/nothing/media/dvb-frontends/au8522_decoder.c >> --- drivers/media/dvb-frontends/au8522_decoder.c >> +++ /tmp/nothing/media/dvb-frontends/au8522_decoder.c >> @@ -280,14 +280,9 @@ static void setup_decoder_defaults(struc >>

Re: [media] duplicate code in media drivers

2018-05-21 Thread Mauro Carvalho Chehab
Em Mon, 21 May 2018 14:39:51 -0500 "Gustavo A. R. Silva" escreveu: > Hi Mauro, > > I found some duplicate code with the help of Coccinelle and Coverity. Notice > that these are not code patches, they only point out the duplicate code in > some media drivers: > > diff -u -p drivers/media/pci/b

[media] duplicate code in media drivers

2018-05-21 Thread Gustavo A. R. Silva
Hi Mauro, I found some duplicate code with the help of Coccinelle and Coverity. Notice that these are not code patches, they only point out the duplicate code in some media drivers: diff -u -p drivers/media/pci/bt8xx/dvb-bt8xx.c /tmp/nothing/media/pci/bt8xx/dvb-bt8xx.c --- drivers/media/pci/bt