Re: [media] Add driver for Samsung S5K5BAF camera sensor

2014-01-08 Thread Dan Carpenter
On Wed, Jan 08, 2014 at 12:58:35PM +0100, Andrzej Hajda wrote: > On 01/08/2014 10:58 AM, Dan Carpenter wrote: > > Hello Andrzej Hajda, > > > > The patch 7d459937dc09: "[media] Add driver for Samsung S5K5BAF > > camera sensor" from Dec 5, 2013, leads to the

Re: [media] Add driver for Samsung S5K5BAF camera sensor

2014-01-08 Thread Andrzej Hajda
On 01/08/2014 10:58 AM, Dan Carpenter wrote: > Hello Andrzej Hajda, > > The patch 7d459937dc09: "[media] Add driver for Samsung S5K5BAF > camera sensor" from Dec 5, 2013, leads to the following > static checker warning: > > drivers/media/i2c/s5k5baf.c:1043 s

Re: [media] Add driver for Samsung S5K5BAF camera sensor

2014-01-08 Thread Sachin Kamat
Hi Dan, On 8 January 2014 14:39, Dan Carpenter wrote: > Hello Andrzej Hajda, > > This is a semi-automatic email about new static checker warnings. > > The patch 7d459937dc09: "[media] Add driver for Samsung S5K5BAF > camera sensor" from Dec 5, 2013, leads to the

re: [media] Add driver for Samsung S5K5BAF camera sensor

2014-01-08 Thread Dan Carpenter
Hello Andrzej Hajda, The patch 7d459937dc09: "[media] Add driver for Samsung S5K5BAF camera sensor" from Dec 5, 2013, leads to the following static checker warning: drivers/media/i2c/s5k5baf.c:1043 s5k5baf_set_power() warn: add some parenthesis here? drivers/media/i2c

re: [media] Add driver for Samsung S5K5BAF camera sensor

2014-01-08 Thread Dan Carpenter
Hello Andrzej Hajda, This is a semi-automatic email about new static checker warnings. The patch 7d459937dc09: "[media] Add driver for Samsung S5K5BAF camera sensor" from Dec 5, 2013, leads to the following Smatch complaint: drivers/media/i2c/s5k5baf.c:554 s5k5baf_fw_get_seq()