Re: [Security] [PATCH 00/20] world-writable files in sysfs and debugfs

2011-03-15 Thread James Bottomley
On Tue, 2011-03-15 at 19:08 +0300, Vasiliy Kulikov wrote: > On Tue, Mar 15, 2011 at 07:50 -0400, James Bottomley wrote: > > 1. Did anyone actually check for capabilities before assuming world > > writeable files were wrong? > > I didn't check all these files as I haven't got these har

Re: [Security] [PATCH 00/20] world-writable files in sysfs and debugfs

2011-03-15 Thread Vasiliy Kulikov
On Tue, Mar 15, 2011 at 07:50 -0400, James Bottomley wrote: > 1. Did anyone actually check for capabilities before assuming world > writeable files were wrong? I didn't check all these files as I haven't got these hardware :-) But as I can "chmod a+w" all sysfs files on my machine an

Re: [Security] [PATCH 00/20] world-writable files in sysfs and debugfs

2011-03-15 Thread James Bottomley
On Tue, 2011-03-15 at 07:18 -0700, Greg KH wrote: > On Tue, Mar 15, 2011 at 07:50:28AM -0400, James Bottomley wrote: > > On Mon, 2011-03-14 at 20:09 -0700, Greg KH wrote: > > > There are no capability checks on sysfs files right now, so these all > > > need to be fixed. > > > > That statement is t

Re: [Security] [PATCH 00/20] world-writable files in sysfs and debugfs

2011-03-15 Thread Greg KH
On Tue, Mar 15, 2011 at 07:50:28AM -0400, James Bottomley wrote: > On Mon, 2011-03-14 at 20:09 -0700, Greg KH wrote: > > On Mon, Mar 14, 2011 at 10:26:05PM -0400, James Bottomley wrote: > > > On Sat, 2011-03-12 at 23:23 +0300, Vasiliy Kulikov wrote: > > > > > Vasiliy Kulikov (20): > > > > > mach-u

Re: [Security] [PATCH 00/20] world-writable files in sysfs and debugfs

2011-03-15 Thread James Bottomley
On Mon, 2011-03-14 at 20:09 -0700, Greg KH wrote: > On Mon, Mar 14, 2011 at 10:26:05PM -0400, James Bottomley wrote: > > On Sat, 2011-03-12 at 23:23 +0300, Vasiliy Kulikov wrote: > > > > Vasiliy Kulikov (20): > > > > mach-ux500: mbox-db5500: world-writable sysfs fifo file > > > > leds: lp5521: wo

Re: [Security] [PATCH 00/20] world-writable files in sysfs and debugfs

2011-03-14 Thread Greg KH
On Mon, Mar 14, 2011 at 10:26:05PM -0400, James Bottomley wrote: > On Sat, 2011-03-12 at 23:23 +0300, Vasiliy Kulikov wrote: > > > Vasiliy Kulikov (20): > > > mach-ux500: mbox-db5500: world-writable sysfs fifo file > > > leds: lp5521: world-writable sysfs engine* files > > > leds: lp5523: world-

Re: [Security] [PATCH 00/20] world-writable files in sysfs and debugfs

2011-03-14 Thread Andrew Morton
On Sat, 12 Mar 2011 23:23:06 +0300 Vasiliy Kulikov wrote: > > Vasiliy Kulikov (20): > > mach-ux500: mbox-db5500: world-writable sysfs fifo file > > leds: lp5521: world-writable sysfs engine* files > > leds: lp5523: world-writable engine* sysfs files > > misc: ep93xx_pwm: world-writable sysfs