Re: [RFCv2 PATCH 0/5] Use control framework in cafe_ccic and s_config removal

2011-01-10 Thread Hans Verkuil
On Monday, January 10, 2011 12:08:42 Hans Verkuil wrote: > > Hi, > > > >>> Another reason why s_config is a bad idea. > > > > Thanks a lot for working on this. I had a quick look and don't have > > any objections. > > > >>> This has been extensively tested on my humble OLPC laptop (and it took > >>

Re: [RFCv2 PATCH 0/5] Use control framework in cafe_ccic and s_config removal

2011-01-10 Thread Hans Verkuil
> Hi, > >>> Another reason why s_config is a bad idea. > > Thanks a lot for working on this. I had a quick look and don't have > any objections. > >>> This has been extensively tested on my humble OLPC laptop (and it took >>> me 4-5 >>> hours just to get the damn thing up and running with these dri

Re: [RFCv2 PATCH 0/5] Use control framework in cafe_ccic and s_config removal

2011-01-10 Thread Daniel Drake
Hi, >> Another reason why s_config is a bad idea. Thanks a lot for working on this. I had a quick look and don't have any objections. >> This has been extensively tested on my humble OLPC laptop (and it took me 4-5 >> hours just to get the damn thing up and running with these drivers). In futur

Re: [RFCv2 PATCH 0/5] Use control framework in cafe_ccic and s_config removal

2011-01-09 Thread Laurent Pinchart
Hi Hans, On Saturday 08 January 2011 12:01:43 Hans Verkuil wrote: > Second version of this patch. Changes are: > > - Handle the return code of the internal 'registered' op and 'unregistered' > now returns a void. > - has_new has been renamed to is_new and is documented and no longer > internal.

Re: [RFCv2 PATCH 0/5] Use control framework in cafe_ccic and s_config removal

2011-01-09 Thread Hans Verkuil
On Sunday, January 09, 2011 17:55:40 Jonathan Corbet wrote: > On Sat, 8 Jan 2011 12:01:43 +0100 > Hans Verkuil wrote: > > > This patch series converts the OLPC cafe_ccic driver to the new control > > framework. It turned out that this depended on the removal of the legacy > > s_config subdev ope

Re: [RFCv2 PATCH 0/5] Use control framework in cafe_ccic and s_config removal

2011-01-09 Thread Jonathan Corbet
On Sat, 8 Jan 2011 12:01:43 +0100 Hans Verkuil wrote: > This patch series converts the OLPC cafe_ccic driver to the new control > framework. It turned out that this depended on the removal of the legacy > s_config subdev operation. I originally created the ov7670 controls in > s_config, but it t

[RFCv2 PATCH 0/5] Use control framework in cafe_ccic and s_config removal

2011-01-08 Thread Hans Verkuil
Second version of this patch. Changes are: - Handle the return code of the internal 'registered' op and 'unregistered' now returns a void. - has_new has been renamed to is_new and is documented and no longer internal. Original cover letter: Hi Jon, Laurent, This patch series converts the OLPC c