Re: [RFCv1 PATCH 7/7] tuner-core: s_tuner should not change tuner mode.

Em 12-06-2011 12:34, Andy Walls escreveu: > Devin Heitmueller wrote: > >> On Sun, Jun 12, 2011 at 9:44 AM, Andy Walls >> wrote: >>> BTW, the cx18-alsa module annoys me as a developer. PulseAudio holds >>> the device nodes open, pinning the cx18-alsa and cx18 modules in >> kernel. >>> When kille

Re: [RFCv1 PATCH 7/7] tuner-core: s_tuner should not change tuner mode.

Devin Heitmueller wrote: >On Sun, Jun 12, 2011 at 9:44 AM, Andy Walls >wrote: >> BTW, the cx18-alsa module annoys me as a developer.  PulseAudio holds >> the device nodes open, pinning the cx18-alsa and cx18 modules in >kernel. >> When killed, PulseAudio respawns rapidly and reopens the nodes. >

Re: [RFCv1 PATCH 7/7] tuner-core: s_tuner should not change tuner mode.

Hans Verkuil wrote: >On Sunday, June 12, 2011 16:11:30 Mauro Carvalho Chehab wrote: >> Em 12-06-2011 09:23, Hans Verkuil escreveu: >> > That's not unreasonably to do at some point in time, but it doesn't >actually >> > answer my question, which is: should the core refuse >VIDIOC_S_FREQUENCY calls

Re: [RFCv1 PATCH 7/7] tuner-core: s_tuner should not change tuner mode.

On Sunday, June 12, 2011 16:11:30 Mauro Carvalho Chehab wrote: > Em 12-06-2011 09:23, Hans Verkuil escreveu: > > That's not unreasonably to do at some point in time, but it doesn't actually > > answer my question, which is: should the core refuse VIDIOC_S_FREQUENCY > > calls > > where the type doe

Re: [RFCv1 PATCH 7/7] tuner-core: s_tuner should not change tuner mode.

Em 12-06-2011 10:57, Devin Heitmueller escreveu: > On Sun, Jun 12, 2011 at 9:44 AM, Andy Walls wrote: >> BTW, the cx18-alsa module annoys me as a developer. PulseAudio holds >> the device nodes open, pinning the cx18-alsa and cx18 modules in kernel. >> When killed, PulseAudio respawns rapidly and

Re: [RFCv1 PATCH 7/7] tuner-core: s_tuner should not change tuner mode.

Em 12-06-2011 09:23, Hans Verkuil escreveu: > On Sunday, June 12, 2011 13:59:59 Mauro Carvalho Chehab wrote: >> Em 12-06-2011 08:36, Hans Verkuil escreveu: >>> On Saturday, June 11, 2011 21:04:57 Mauro Carvalho Chehab wrote: Em 11-06-2011 14:27, Hans Verkuil escreveu: > On Saturday, June 1

Re: [RFCv1 PATCH 7/7] tuner-core: s_tuner should not change tuner mode.

On Sunday, June 12, 2011 15:44:45 Andy Walls wrote: > On Sun, 2011-06-12 at 15:23 +0200, Hans Verkuil wrote: > > On Sunday, June 12, 2011 14:53:06 Andy Walls wrote: > > > On Sun, 2011-06-12 at 14:30 +0200, Hans Verkuil wrote: > > > > On Sunday, June 12, 2011 14:13:30 Mauro Carvalho Chehab wrote: >

Re: [RFCv1 PATCH 7/7] tuner-core: s_tuner should not change tuner mode.

On Sun, Jun 12, 2011 at 9:44 AM, Andy Walls wrote: > BTW, the cx18-alsa module annoys me as a developer.  PulseAudio holds > the device nodes open, pinning the cx18-alsa and cx18 modules in kernel. > When killed, PulseAudio respawns rapidly and reopens the nodes. > Unloading cx18 for development p

Re: [RFCv1 PATCH 7/7] tuner-core: s_tuner should not change tuner mode.

On Sun, 2011-06-12 at 15:23 +0200, Hans Verkuil wrote: > On Sunday, June 12, 2011 14:53:06 Andy Walls wrote: > > On Sun, 2011-06-12 at 14:30 +0200, Hans Verkuil wrote: > > > On Sunday, June 12, 2011 14:13:30 Mauro Carvalho Chehab wrote: > > > > Em 12-06-2011 08:59, Mauro Carvalho Chehab escreveu: >

Re: [RFCv1 PATCH 7/7] tuner-core: s_tuner should not change tuner mode.

On Sunday, June 12, 2011 14:53:06 Andy Walls wrote: > On Sun, 2011-06-12 at 14:30 +0200, Hans Verkuil wrote: > > On Sunday, June 12, 2011 14:13:30 Mauro Carvalho Chehab wrote: > > > Em 12-06-2011 08:59, Mauro Carvalho Chehab escreveu: > > > > Em 12-06-2011 08:36, Hans Verkuil escreveu: > > > W

Re: [RFCv1 PATCH 7/7] tuner-core: s_tuner should not change tuner mode.

On Sun, 2011-06-12 at 14:30 +0200, Hans Verkuil wrote: > On Sunday, June 12, 2011 14:13:30 Mauro Carvalho Chehab wrote: > > Em 12-06-2011 08:59, Mauro Carvalho Chehab escreveu: > > > Em 12-06-2011 08:36, Hans Verkuil escreveu: > > What about this: > > > > Opening /dev/radio effective

Re: [RFCv1 PATCH 7/7] tuner-core: s_tuner should not change tuner mode.

On Sunday, June 12, 2011 14:13:30 Mauro Carvalho Chehab wrote: > Em 12-06-2011 08:59, Mauro Carvalho Chehab escreveu: > > Em 12-06-2011 08:36, Hans Verkuil escreveu: > What about this: > > Opening /dev/radio effectively starts the radio mode. So if there is TV > capture in progr

Re: [RFCv1 PATCH 7/7] tuner-core: s_tuner should not change tuner mode.

On Sunday, June 12, 2011 13:59:59 Mauro Carvalho Chehab wrote: > Em 12-06-2011 08:36, Hans Verkuil escreveu: > > On Saturday, June 11, 2011 21:04:57 Mauro Carvalho Chehab wrote: > >> Em 11-06-2011 14:27, Hans Verkuil escreveu: > >>> On Saturday, June 11, 2011 15:54:59 Mauro Carvalho Chehab wrote: >

Re: [RFCv1 PATCH 7/7] tuner-core: s_tuner should not change tuner mode.

Em 12-06-2011 08:59, Mauro Carvalho Chehab escreveu: > Em 12-06-2011 08:36, Hans Verkuil escreveu: >> On Saturday, June 11, 2011 21:04:57 Mauro Carvalho Chehab wrote: >>> Em 11-06-2011 14:27, Hans Verkuil escreveu: On Saturday, June 11, 2011 15:54:59 Mauro Carvalho Chehab wrote: > Em 11-06

Re: [RFCv1 PATCH 7/7] tuner-core: s_tuner should not change tuner mode.

Em 12-06-2011 08:36, Hans Verkuil escreveu: > On Saturday, June 11, 2011 21:04:57 Mauro Carvalho Chehab wrote: >> Em 11-06-2011 14:27, Hans Verkuil escreveu: >>> On Saturday, June 11, 2011 15:54:59 Mauro Carvalho Chehab wrote: Em 11-06-2011 10:34, Hans Verkuil escreveu: > From: Hans Verkui

Re: [RFCv1 PATCH 7/7] tuner-core: s_tuner should not change tuner mode.

On Saturday, June 11, 2011 21:04:57 Mauro Carvalho Chehab wrote: > Em 11-06-2011 14:27, Hans Verkuil escreveu: > > On Saturday, June 11, 2011 15:54:59 Mauro Carvalho Chehab wrote: > >> Em 11-06-2011 10:34, Hans Verkuil escreveu: > >>> From: Hans Verkuil > >>> > >>> According to the spec the tuner

Re: [RFCv1 PATCH 7/7] tuner-core: s_tuner should not change tuner mode.

Em 11-06-2011 14:27, Hans Verkuil escreveu: > On Saturday, June 11, 2011 15:54:59 Mauro Carvalho Chehab wrote: >> Em 11-06-2011 10:34, Hans Verkuil escreveu: >>> From: Hans Verkuil >>> >>> According to the spec the tuner type field is not used when calling >>> S_TUNER: index, audmode and reserved

Re: [RFCv1 PATCH 7/7] tuner-core: s_tuner should not change tuner mode.

Hans Verkuil wrote: >On Saturday, June 11, 2011 15:54:59 Mauro Carvalho Chehab wrote: >> Em 11-06-2011 10:34, Hans Verkuil escreveu: >> > From: Hans Verkuil >> > >> > According to the spec the tuner type field is not used when calling >> > S_TUNER: index, audmode and reserved are the only writa

Re: [RFCv1 PATCH 7/7] tuner-core: s_tuner should not change tuner mode.

On Saturday, June 11, 2011 15:54:59 Mauro Carvalho Chehab wrote: > Em 11-06-2011 10:34, Hans Verkuil escreveu: > > From: Hans Verkuil > > > > According to the spec the tuner type field is not used when calling > > S_TUNER: index, audmode and reserved are the only writable fields. > > > > So remo

Re: [RFCv1 PATCH 7/7] tuner-core: s_tuner should not change tuner mode.

Em 11-06-2011 10:34, Hans Verkuil escreveu: > From: Hans Verkuil > > According to the spec the tuner type field is not used when calling > S_TUNER: index, audmode and reserved are the only writable fields. > > So remove the type check. Instead, just set the audmode if the current > tuner mode is

[RFCv1 PATCH 7/7] tuner-core: s_tuner should not change tuner mode.

From: Hans Verkuil According to the spec the tuner type field is not used when calling S_TUNER: index, audmode and reserved are the only writable fields. So remove the type check. Instead, just set the audmode if the current tuner mode is set to radio. Signed-off-by: Hans Verkuil --- drivers/