Re: [RFCv1 PATCH 4/9] v4l2-ctrls: add per-control events.

2011-04-21 Thread Hans Verkuil
On Thursday, April 21, 2011 13:41:01 Sakari Ailus wrote: > Laurent Pinchart wrote: > > Hi Sakari, > > Hi Laurent, > > > On Saturday 16 April 2011 10:51:27 Sakari Ailus wrote: > >> Hans Verkuil wrote: > Hans Verkuil wrote: > > Whenever a control changes value an event is sent to anyone th

Re: [RFCv1 PATCH 4/9] v4l2-ctrls: add per-control events.

2011-04-21 Thread Sakari Ailus
Laurent Pinchart wrote: > Hi Sakari, Hi Laurent, > On Saturday 16 April 2011 10:51:27 Sakari Ailus wrote: >> Hans Verkuil wrote: Hans Verkuil wrote: > Whenever a control changes value an event is sent to anyone that > subscribed > to it. > > Signed-off-by: Hans Verkuil >

Re: [RFCv1 PATCH 4/9] v4l2-ctrls: add per-control events.

2011-04-19 Thread Laurent Pinchart
Hi Sakari, On Saturday 16 April 2011 10:51:27 Sakari Ailus wrote: > Hans Verkuil wrote: > >> Hans Verkuil wrote: > >>> Whenever a control changes value an event is sent to anyone that > >>> subscribed > >>> to it. > >>> > >>> Signed-off-by: Hans Verkuil > >>> --- > >>> > >>> drivers/media/vide

Re: [RFCv1 PATCH 4/9] v4l2-ctrls: add per-control events.

2011-04-16 Thread Sakari Ailus
Hi Hans, Thanks for the reply. Hans Verkuil wrote: >> Hi Hans, >> >> I have some more comments below. :-) >> >> Hans Verkuil wrote: >>> Whenever a control changes value an event is sent to anyone that >>> subscribed >>> to it. >>> >>> Signed-off-by: Hans Verkuil >>> --- >>> drivers/media/video/

Re: [RFCv1 PATCH 4/9] v4l2-ctrls: add per-control events.

2011-04-15 Thread Hans Verkuil
> Hi Hans, > > I have some more comments below. :-) > > Hans Verkuil wrote: >> Whenever a control changes value an event is sent to anyone that >> subscribed >> to it. >> >> Signed-off-by: Hans Verkuil >> --- >> drivers/media/video/v4l2-ctrls.c | 59 ++ >> drivers/media/video/v4

Re: [RFCv1 PATCH 4/9] v4l2-ctrls: add per-control events.

2011-04-15 Thread Sakari Ailus
Hi Hans, I have some more comments below. :-) Hans Verkuil wrote: > Whenever a control changes value an event is sent to anyone that subscribed > to it. > > Signed-off-by: Hans Verkuil > --- > drivers/media/video/v4l2-ctrls.c | 59 ++ > drivers/media/video/v4l2-event.c | 126

Re: [RFCv1 PATCH 4/9] v4l2-ctrls: add per-control events.

2011-04-12 Thread Hans Verkuil
> Hi Hans, > > Hans Verkuil wrote: >>> + union { + __s32 value; + __s64 value64; + }; +} __attribute__ ((packed)); + struct v4l2_event { __u32 type; union { struct v4l2_event_vsync vsyn

Re: [RFCv1 PATCH 4/9] v4l2-ctrls: add per-control events.

2011-04-12 Thread Sakari Ailus
Hi Hans, Hans Verkuil wrote: [clip] >>> diff --git a/drivers/media/video/v4l2-fh.c >>> b/drivers/media/video/v4l2-fh.c >>> index 8635011..c6aef84 100644 >>> --- a/drivers/media/video/v4l2-fh.c >>> +++ b/drivers/media/video/v4l2-fh.c >>> @@ -93,10 +93,8 @@ void v4l2_fh_exit(struct v4l2_fh *fh) >>>

Re: [RFCv1 PATCH 4/9] v4l2-ctrls: add per-control events.

2011-04-11 Thread Hans Verkuil
> Hi Hans, > > Thanks for the patchset! This looks really nice! > > Hans Verkuil wrote: >> Whenever a control changes value an event is sent to anyone that >> subscribed >> to it. >> >> Signed-off-by: Hans Verkuil >> --- >> drivers/media/video/v4l2-ctrls.c | 59 ++ >> drivers/me

Re: [RFCv1 PATCH 4/9] v4l2-ctrls: add per-control events.

2011-04-11 Thread Sakari Ailus
Hi Hans, Thanks for the patchset! This looks really nice! Hans Verkuil wrote: > Whenever a control changes value an event is sent to anyone that subscribed > to it. > > Signed-off-by: Hans Verkuil > --- > drivers/media/video/v4l2-ctrls.c | 59 ++ > drivers/media/video/v4l2-ev

[RFCv1 PATCH 4/9] v4l2-ctrls: add per-control events.

2011-04-04 Thread Hans Verkuil
Whenever a control changes value an event is sent to anyone that subscribed to it. Signed-off-by: Hans Verkuil --- drivers/media/video/v4l2-ctrls.c | 59 ++ drivers/media/video/v4l2-event.c | 126 +++--- drivers/media/video/v4l2-fh.c|4 +