Re: [RFCv1 PATCH 1/8] v4l2-events/fh: merge v4l2_events into v4l2_fh

2011-06-15 Thread Hans Verkuil
On Wednesday, June 15, 2011 18:59:05 Sakari Ailus wrote: > Hans Verkuil wrote: > > On Wednesday, June 15, 2011 11:30:07 Sakari Ailus wrote: > >> Hi Hans, > >> > >> Many thanks for the patch. I'm very happy to see this! > >> > >> I have just one comment below. > >> > >>> diff --git a/include/media/v

Re: [RFCv1 PATCH 1/8] v4l2-events/fh: merge v4l2_events into v4l2_fh

2011-06-15 Thread Sakari Ailus
Hans Verkuil wrote: On Wednesday, June 15, 2011 11:30:07 Sakari Ailus wrote: Hi Hans, Many thanks for the patch. I'm very happy to see this! I have just one comment below. diff --git a/include/media/v4l2-event.h b/include/media/v4l2-event.h index 45e9c1e..042b893 100644 --- a/include/media/v

Re: [RFCv1 PATCH 1/8] v4l2-events/fh: merge v4l2_events into v4l2_fh

2011-06-15 Thread Hans Verkuil
On Wednesday, June 15, 2011 11:30:07 Sakari Ailus wrote: > Hi Hans, > > Many thanks for the patch. I'm very happy to see this! > > I have just one comment below. > > > diff --git a/include/media/v4l2-event.h b/include/media/v4l2-event.h > > index 45e9c1e..042b893 100644 > > --- a/include/media/v

Re: [RFCv1 PATCH 1/8] v4l2-events/fh: merge v4l2_events into v4l2_fh

2011-06-15 Thread Sakari Ailus
Hi Hans, Many thanks for the patch. I'm very happy to see this! I have just one comment below. > diff --git a/include/media/v4l2-event.h b/include/media/v4l2-event.h > index 45e9c1e..042b893 100644 > --- a/include/media/v4l2-event.h > +++ b/include/media/v4l2-event.h > @@ -43,17 +43,6 @@ struct

[RFCv1 PATCH 1/8] v4l2-events/fh: merge v4l2_events into v4l2_fh

2011-06-14 Thread Hans Verkuil
From: Hans Verkuil Drivers that supported events used to be rare, but now that controls can also raise events this will become much more common since almost all drivers have controls. This means that keeping struct v4l2_events as a separate struct make no more sense. Merging it into struct v4l2_