Re: [RFC RESEND 07/11] vb2: dma-contig: Remove redundant sgt_base field

2016-12-16 Thread Sakari Ailus
On Thu, Dec 15, 2016 at 11:08:37PM +0200, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Friday 11 Sep 2015 14:50:30 Sakari Ailus wrote: > > The struct vb2_dc_buf contains two struct sg_table fields: sgt_base and > > dma_sgt. The former is used by DMA-BUF buffers whereas

Re: [RFC RESEND 07/11] vb2: dma-contig: Remove redundant sgt_base field

2016-12-15 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Friday 11 Sep 2015 14:50:30 Sakari Ailus wrote: > The struct vb2_dc_buf contains two struct sg_table fields: sgt_base and > dma_sgt. The former is used by DMA-BUF buffers whereas the latter is used > by USERPTR. > > Unify the two, leaving dma_sgt. Looks go

Re: [RFC RESEND 07/11] vb2: dma-contig: Remove redundant sgt_base field

2015-09-15 Thread Sakari Ailus
Hi Hans, Hans Verkuil wrote: > On 09/11/2015 01:50 PM, Sakari Ailus wrote: >> The struct vb2_dc_buf contains two struct sg_table fields: sgt_base and >> dma_sgt. The former is used by DMA-BUF buffers whereas the latter is used >> by USERPTR. >> >> Unify the two, leaving dma_sgt. >> >> MMAP buffers

Re: [RFC RESEND 07/11] vb2: dma-contig: Remove redundant sgt_base field

2015-09-11 Thread Hans Verkuil
On 09/11/2015 01:50 PM, Sakari Ailus wrote: > The struct vb2_dc_buf contains two struct sg_table fields: sgt_base and > dma_sgt. The former is used by DMA-BUF buffers whereas the latter is used > by USERPTR. > > Unify the two, leaving dma_sgt. > > MMAP buffers do not need cache flushing since the

[RFC RESEND 07/11] vb2: dma-contig: Remove redundant sgt_base field

2015-09-11 Thread Sakari Ailus
The struct vb2_dc_buf contains two struct sg_table fields: sgt_base and dma_sgt. The former is used by DMA-BUF buffers whereas the latter is used by USERPTR. Unify the two, leaving dma_sgt. MMAP buffers do not need cache flushing since they have been allocated using dma_alloc_coherent(). Signed-