Re: [RFC PATCHv2] fixp-arith: replace sin/cos table by a better precision one

2014-12-17 Thread Mauro Carvalho Chehab
Em Wed, 17 Dec 2014 19:11:33 + "Prashant Laddha (prladdha)" escreveu: > Hi Mauro, > > I was able to test your patch with vivid sdr tone generation. It calls > sin/cos functions with radians as argument. I find that the sine wave > generated using fixp_sin32_rad() show discontinuities, especi

Re: [RFC PATCHv2] fixp-arith: replace sin/cos table by a better precision one

2014-12-17 Thread Prashant Laddha (prladdha)
Hi Mauro, I was able to test your patch with vivid sdr tone generation. It calls sin/cos functions with radians as argument. I find that the sine wave generated using fixp_sin32_rad() show discontinuities, especially around 90, 180 degrees. After debugging it further, these discontinuities seems t

[RFC PATCHv2] fixp-arith: replace sin/cos table by a better precision one

2014-12-17 Thread Mauro Carvalho Chehab
The cos table used at fixp-arith.h has only 8 bits of precision. That causes problems if it is reused on other drivers. As some media drivers require a higher precision sin/cos implementation, replace the current implementation by one that will provide 32 bits precision. The values generated by t