Re: [RFC PATCH v5] media: add v4l2 subdev driver for S5K4ECGX sensor

2012-09-06 Thread Sangwook Lee
Hi Sylwester Thank you for the review again. On 5 September 2012 22:56, Sylwester Nawrocki wrote: > Hi Sangwook, > > On 09/05/2012 02:28 PM, Sangwook Lee wrote: [snip] >> +#include > > What do we need this header for ? Ok, let me delete this. > >> + >> +#include >> +#include >> +#include >> +#

Re: [RFC PATCH v5] media: add v4l2 subdev driver for S5K4ECGX sensor

2012-09-05 Thread Sylwester Nawrocki
Hi Sangwook, On 09/05/2012 02:28 PM, Sangwook Lee wrote: > This patch adds driver for S5K4ECGX sensor with embedded ISP SoC, > S5K4ECGX, which is a 5M CMOS Image sensor from Samsung > The driver implements preview mode of the S5K4ECGX sensor. > capture (snapshot) operation, face detection are miss

[RFC PATCH v5] media: add v4l2 subdev driver for S5K4ECGX sensor

2012-09-05 Thread Sangwook Lee
This patch adds driver for S5K4ECGX sensor with embedded ISP SoC, S5K4ECGX, which is a 5M CMOS Image sensor from Samsung The driver implements preview mode of the S5K4ECGX sensor. capture (snapshot) operation, face detection are missing now. Following controls are supported: contrast/saturation/bri