Re: [RFC PATCH v3 2/5] media: videobuf2: Restructure vb2_buffer

2015-08-31 Thread Hans Verkuil
On 08/31/2015 09:56 AM, Junghak Sung wrote: > > > On 08/31/2015 11:01 AM, Junghak Sung wrote: >> Hello Hans, >> >> Thank you for your review. >> I leave some comments in the body for reply. >> >> Regards, >> Junghak >> >> >> >> On 08/28/2015 10:31 PM, Hans Verkuil wrote: >>> Hi Junghak, >>> >>> T

Re: [RFC PATCH v3 2/5] media: videobuf2: Restructure vb2_buffer

2015-08-31 Thread Junghak Sung
On 08/31/2015 11:01 AM, Junghak Sung wrote: Hello Hans, Thank you for your review. I leave some comments in the body for reply. Regards, Junghak On 08/28/2015 10:31 PM, Hans Verkuil wrote: Hi Junghak, Thanks for this patch, it looks much better. I do have a number of comments, though...

Re: [RFC PATCH v3 2/5] media: videobuf2: Restructure vb2_buffer

2015-08-30 Thread Junghak Sung
Hello Hans, Thank you for your review. I leave some comments in the body for reply. Regards, Junghak On 08/28/2015 10:31 PM, Hans Verkuil wrote: Hi Junghak, Thanks for this patch, it looks much better. I do have a number of comments, though... On 08/26/2015 01:59 PM, Junghak Sung wrote:

Re: [RFC PATCH v3 2/5] media: videobuf2: Restructure vb2_buffer

2015-08-28 Thread Hans Verkuil
Hi Junghak, Thanks for this patch, it looks much better. I do have a number of comments, though... On 08/26/2015 01:59 PM, Junghak Sung wrote: > Remove v4l2-specific stuff from struct vb2_buffer and add member variables > related with buffer management. > > struct vb2_plane { > >

Re: [RFC PATCH v3 2/5] media: videobuf2: Restructure vb2_buffer

2015-08-28 Thread Mauro Carvalho Chehab
Em Fri, 28 Aug 2015 10:26:48 +0900 Junghak Sung escreveu: > > Hello Mauro, > > First of all, thank you for your detailed review. > > > On 08/27/2015 07:28 PM, Mauro Carvalho Chehab wrote: > > Em Wed, 26 Aug 2015 20:59:29 +0900 > > Junghak Sung escreveu: > > > >> Remove v4l2-specific stuff fr

Re: [RFC PATCH v3 2/5] media: videobuf2: Restructure vb2_buffer

2015-08-27 Thread Junghak Sung
Hello Mauro, First of all, thank you for your detailed review. On 08/27/2015 07:28 PM, Mauro Carvalho Chehab wrote: Em Wed, 26 Aug 2015 20:59:29 +0900 Junghak Sung escreveu: Remove v4l2-specific stuff from struct vb2_buffer and add member variables related with buffer management. struct v

Re: [RFC PATCH v3 2/5] media: videobuf2: Restructure vb2_buffer

2015-08-27 Thread Mauro Carvalho Chehab
Em Wed, 26 Aug 2015 20:59:29 +0900 Junghak Sung escreveu: > Remove v4l2-specific stuff from struct vb2_buffer and add member variables > related with buffer management. > > struct vb2_plane { > > /* plane information */ > unsigned intbytesused; > unsi

[RFC PATCH v3 2/5] media: videobuf2: Restructure vb2_buffer

2015-08-26 Thread Junghak Sung
Remove v4l2-specific stuff from struct vb2_buffer and add member variables related with buffer management. struct vb2_plane { /* plane information */ unsigned intbytesused; unsigned intlength; union { unsigned int