Re: [RFC PATCH v1 5/7] media: v4l2: introduce two IOCTLs for face detection

2011-12-27 Thread Sylwester Nawrocki
Hi Ming, On 12/26/2011 03:00 AM, Ming Lei wrote: > On Thu, Dec 22, 2011 at 3:32 AM, Sylwester Nawrocki wrote: How is face detection enabled or disabled? >>> >>> Currently, streaming on will trigger detection enabling, and streaming >>> off will trigger detection disabling. >> >> We would nee

Re: [RFC PATCH v1 5/7] media: v4l2: introduce two IOCTLs for face detection

2011-12-25 Thread Ming Lei
Hi, On Thu, Dec 22, 2011 at 3:32 AM, Sylwester Nawrocki wrote: >>> How is face detection enabled or disabled? >> >> Currently, streaming on will trigger detection enabling, and streaming off >> will trigger detection disabling. > > We would need to develop a boolean control for this I think, thi

Re: [RFC PATCH v1 5/7] media: v4l2: introduce two IOCTLs for face detection

2011-12-21 Thread Sylwester Nawrocki
Hi Ming, On 12/14/2011 04:57 PM, Ming Lei wrote: > Hi, > > On Wed, Dec 14, 2011 at 11:34 PM, Sakari Ailus wrote: > >>> + case VIDIOC_G_FD_RESULT: >>> + { >>> + struct v4l2_fd_result *fr = arg; >>> + >>> + if (!ops->vidioc_g_fd_result) >>> + br

Re: [RFC PATCH v1 5/7] media: v4l2: introduce two IOCTLs for face detection

2011-12-14 Thread Ming Lei
Hi, On Wed, Dec 14, 2011 at 11:34 PM, Sakari Ailus wrote: >> +     case VIDIOC_G_FD_RESULT: >> +     { >> +             struct v4l2_fd_result *fr = arg; >> + >> +             if (!ops->vidioc_g_fd_result) >> +                     break; >> + >> +             ret = ops->vidioc_g_fd_result(file, f

Re: [RFC PATCH v1 5/7] media: v4l2: introduce two IOCTLs for face detection

2011-12-14 Thread Sakari Ailus
Hi Ming, Thanks for the patchset. (Dropped a lot of folks from cc --- I doubt Alan Cox or Greg Kroah-Hartman have immediate interest towards this.) On Fri, Dec 02, 2011 at 11:02:50PM +0800, Ming Lei wrote: > This patch introduces two new IOCTLs and related data > structure defination which will

Re: [RFC PATCH v1 5/7] media: v4l2: introduce two IOCTLs for face detection

2011-12-11 Thread Sylwester Nawrocki
Hi, On 12/09/2011 05:34 AM, Ming Lei wrote: > + * struct v4l2_obj_detection > + * @buf_index: entry, index of v4l2_buffer for face detection >> >> I would prefer having the frame sequence number here. It will be more >> future proof IMHO. If for instance we decide to use such an ioct

Re: [RFC PATCH v1 5/7] media: v4l2: introduce two IOCTLs for face detection

2011-12-08 Thread Ming Lei
Hi, On Fri, Dec 9, 2011 at 6:27 AM, Sylwester Nawrocki wrote: > On 12/08/2011 04:42 AM, Ming Lei wrote: +/** + * struct v4l2_obj_detection + * @buf_index:       entry, index of v4l2_buffer for face detection > > I would prefer having the frame sequence number here. It will be more

Re: [RFC PATCH v1 5/7] media: v4l2: introduce two IOCTLs for face detection

2011-12-08 Thread Sylwester Nawrocki
On 12/08/2011 04:42 AM, Ming Lei wrote: >>> +/** >>> + * struct v4l2_obj_detection >>> + * @buf_index: entry, index of v4l2_buffer for face detection I would prefer having the frame sequence number here. It will be more future proof IMHO. If for instance we decide to use such an ioctl on a v

Re: [RFC PATCH v1 5/7] media: v4l2: introduce two IOCTLs for face detection

2011-12-07 Thread Ming Lei
Hi, On Tue, Dec 6, 2011 at 6:15 AM, Sylwester Nawrocki wrote: > On 12/02/2011 04:02 PM, Ming Lei wrote: >> This patch introduces two new IOCTLs and related data >> structure defination which will be used by the coming >> face detection video device. >> >> The two IOCTLs and related data structure

Re: [RFC PATCH v1 5/7] media: v4l2: introduce two IOCTLs for face detection

2011-12-05 Thread Sylwester Nawrocki
On 12/02/2011 04:02 PM, Ming Lei wrote: > This patch introduces two new IOCTLs and related data > structure defination which will be used by the coming > face detection video device. > > The two IOCTLs and related data structure are used by > user space application to retrieve the results of face

[RFC PATCH v1 5/7] media: v4l2: introduce two IOCTLs for face detection

2011-12-02 Thread Ming Lei
This patch introduces two new IOCTLs and related data structure defination which will be used by the coming face detection video device. The two IOCTLs and related data structure are used by user space application to retrieve the results of face detection. They can be called after one v4l2_buffer