Re: [RFC PATCH V1 6/6] platform: mtk-isp: Add Mediatek DIP driver

2019-06-25 Thread Frederic Chen
Dear Tomasz, Would you comment on the following points in further? Thank you for the review. On Thu, 2019-05-09 at 18:48 +0900, Tomasz Figa wrote: > Hi Frederic, > [snip] > > +int mtk_dip_pipe_job_start(struct mtk_dip_pipe *dip_pipe, > > + struct mtk_dip_pipe_job_info

Re: [RFC PATCH V1 6/6] platform: mtk-isp: Add Mediatek DIP driver

2019-06-11 Thread Frederic Chen
Dear Tomasz, I'd like to elaborate more about the tuning_data.va. Would you like to give us some advice about our improvement proposal inline? Thank you very much. On Wed, 2019-05-22 at 03:14 +0800, Frederic Chen wrote: > Dear Tomasz, > > I appreciate your comment. It is very helpful for us. >

Re: [RFC PATCH V1 6/6] platform: mtk-isp: Add Mediatek DIP driver

2019-05-23 Thread Frederic Chen
Hi Shilk, I appreciate your comments. On Wed, 2019-05-22 at 17:51 +0800, Shik Chen wrote: > Hi Frederic, > > Most reviews are already covered by Tomasz, here are some small missing > pieces. > Please see my comments inline. > > On Wed, Apr 17, 2019 at 06:45:11PM +0800, Frederic Chen wrote: >

Re: [RFC PATCH V1 6/6] platform: mtk-isp: Add Mediatek DIP driver

2019-05-23 Thread Frederic Chen
Dear Tomasz, Thank you for your comments. On Wed, 2019-05-22 at 19:25 +0900, Tomasz Figa wrote: > Hi Frederic, > > On Wed, May 22, 2019 at 03:14:15AM +0800, Frederic Chen wrote: > > Dear Tomasz, > > > > I appreciate your comment. It is very helpful for us. > > > > You're welcome. Thanks for

Re: [RFC PATCH V1 6/6] platform: mtk-isp: Add Mediatek DIP driver

2019-05-22 Thread Tomasz Figa
Hi Frederic, On Wed, May 22, 2019 at 03:14:15AM +0800, Frederic Chen wrote: > Dear Tomasz, > > I appreciate your comment. It is very helpful for us. > You're welcome. Thanks for replying to all the comments. I'll skip those resolved in my reply to keep the message shorter. > > On Thu, 2019-05

Re: [RFC PATCH V1 6/6] platform: mtk-isp: Add Mediatek DIP driver

2019-05-22 Thread Shik Chen
Hi Frederic, Most reviews are already covered by Tomasz, here are some small missing pieces. Please see my comments inline. On Wed, Apr 17, 2019 at 06:45:11PM +0800, Frederic Chen wrote: > This patch adds the driver of Digital Image Processing (DIP) > unit in Mediatek ISP system, providing image

[RFC PATCH V1 6/6] platform: mtk-isp: Add Mediatek DIP driver

2019-04-17 Thread Frederic Chen
This patch adds the driver of Digital Image Processing (DIP) unit in Mediatek ISP system, providing image format conversion, resizing, and rotation features. The mtk-isp directory will contain drivers for multiple IP blocks found in Mediatek ISP system. It will include ISP Pass 1 driver(CAM), sens