Re: [RFC PATCH 2/8] davinci: vpfe: add IPIPE hardware layer support

2011-08-07 Thread Sakari Ailus
Hi Manju, Thanks for the RFC. I've reviewed it, and there are a few systematic issues but nothing major. I'm not sure if the same also apply to other patches. Notning really related to V4L2 yet. - If function returns no meaningful value it should be void. - Returning early may easily allow uninde

[RFC PATCH 2/8] davinci: vpfe: add IPIPE hardware layer support

2011-06-30 Thread Manjunath Hadli
From: Nagabhushana Netagunte add dm365 IPIPE hardware support. IPIPE is the hardware IP which implements the functionality required for resizer, previewer and the associated feature support. This is built along with the vpfe driver, and implements hardware setup including coeffcient programming f