On Sat July 28 2012 13:11:13 Hans de Goede wrote:
> Hi,
>
> Overall this looks good, but some of the code, for example the set/get freq
> and
> get/set tuner stuff seems to be a 1 on 1 copy of code from v4l2-ctrl, please
> factor this out into a common file which can be shared between both
> util
Hi,
Overall this looks good, but some of the code, for example the set/get freq and
get/set tuner stuff seems to be a 1 on 1 copy of code from v4l2-ctrl, please
factor this out into a common file which can be shared between both
utilities (I think Hans V's recent work on splitting v4l2-ctl into m
On Thu July 26 2012 21:13:08 Gregor Jasny wrote:
> On 7/25/12 7:44 PM, Konke Radlow wrote:
>
> > +static void print_rds_af(struct v4l2_rds_af_set *af_set)
> > +{
> > + int counter = 0;
> > +
> > + printf("\nAnnounced AFs: %u", af_set->announced_af);
> > + for (int i = 0; i < af_set->size &&
1.
> +#ifdef HAVE_SYS_KLOG_H
> +#include
> +#endif
I'll drop those lines
2.
> + case OptSetDevice:
> + strncpy(params.fd_name, optarg, 80);
> + if (optarg[0] >= '0' && optarg[0] <= '9' && optarg[1]
> == 0) {
I didn't know about the isalpha fu
On 7/25/12 7:44 PM, Konke Radlow wrote:
> +static void print_rds_af(struct v4l2_rds_af_set *af_set)
> +{
> + int counter = 0;
> +
> + printf("\nAnnounced AFs: %u", af_set->announced_af);
> + for (int i = 0; i < af_set->size && i < af_set->announced_af; i++,
> counter++) {
> +
On 7/25/12 7:44 PM, Konke Radlow wrote:
> --- /dev/null
> +++ b/utils/rds-ctl/rds-ctl.cpp
> @@ -0,0 +1,978 @@
> +/*
> + * rds-ctl.cpp is based on v4l2-ctl.cpp
> + *
> + * the following applies for all RDS related parts:
> + * Copyright 2012 Cisco Systems, Inc. and/or its affiliates. All rights
>
---
Makefile.am |3 +-
configure.ac |1 +
utils/rds-ctl/Makefile.am |5 +
utils/rds-ctl/rds-ctl.cpp | 978 +
4 files changed, 986 insertions(+), 1 deletion(-)
create mode 100644 utils/rds-ctl/Makefile.am
create m
