On Mon, Aug 29, 2011 at 08:49:30PM +0530, Hadli, Manjunath wrote:
>
> Sakari,
Hi Manju,
> I have sent a fresh patch-set with your comments fixed and and some
> cleanup and reorg of my own- mainly the headers. Please review.
I'll try to review at the patches when I have time.
> Also, I h
Sakari,
I have sent a fresh patch-set with your comments fixed and and some
cleanup and reorg of my own- mainly the headers. Please review.
Also, I had to keep one of your comments without code change as I felt it was
Ok to keep it here as it is only a local variable which actually get
Hadli, Manjunath wrote:
> Sakari, Thank you for your comments. I agree with them and fix.
> Please comment
on the rest of the patches as well.
> -Manju>
Hi Manju,
I'll attempt to find more time for this.
[clip]
>>> +/* CFG1 Masks and shifts */
>>> +#define ONESHOT_SHIFT (0)
Sakari,
Thank you for your comments. I agree with them and fix. Please comment on the
rest of the patches as well.
-Manju
On Thu, Jul 14, 2011 at 00:20:50, Sakari Ailus wrote:
> Hi Manju,
>
> Thanks for the patchset!
>
> I have a few comments on this patch below. I haven't read the rest of the
Hi Manju,
Thanks for the patchset!
I have a few comments on this patch below. I haven't read the rest of the
patches yet so I may have more comments on this one when I do that.
On Thu, Jun 30, 2011 at 06:43:10PM +0530, Manjunath Hadli wrote:
> add support for dm3xx IPIPEIF hardware setup. This i
add support for dm3xx IPIPEIF hardware setup. This is the
lowest software layer for the dm3x vpfe driver which directly
accesses hardware. Add support for features like default
pixel correction, dark frame substraction and hardware setup.
Signed-off-by: Manjunath Hadli
Signed-off-by: Nagabhushan
