Re: [RFC PATCH 1/2] Add libv4l2rds library (with changes proposed in RFC)

2012-08-10 Thread Hans de Goede
Hi, On 08/10/2012 09:36 AM, Hans Verkuil wrote: On Fri 10 August 2012 09:16:34 Hans de Goede wrote: Hi, On 08/09/2012 02:14 PM, Hans Verkuil wrote: On Thu August 9 2012 13:58:07 Hans de Goede wrote: Hi Konke, As Gregor already mentioned there is no need to define libv4l2rdssubdir in config

Re: [RFC PATCH 1/2] Add libv4l2rds library (with changes proposed in RFC)

2012-08-10 Thread Hans Verkuil
On Fri 10 August 2012 09:16:34 Hans de Goede wrote: > Hi, > > On 08/09/2012 02:14 PM, Hans Verkuil wrote: > > On Thu August 9 2012 13:58:07 Hans de Goede wrote: > >> Hi Konke, > >> > >> As Gregor already mentioned there is no need to define libv4l2rdssubdir in > >> configure.ac , > >> so please d

Re: [RFC PATCH 1/2] Add libv4l2rds library (with changes proposed in RFC)

2012-08-10 Thread Hans de Goede
Hi, On 08/09/2012 02:14 PM, Hans Verkuil wrote: On Thu August 9 2012 13:58:07 Hans de Goede wrote: Hi Konke, As Gregor already mentioned there is no need to define libv4l2rdssubdir in configure.ac , so please drop that. Other then that I've some minor remarks (comments inline), with all thos

Re: [RFC PATCH 1/2] Add libv4l2rds library (with changes proposed in RFC)

2012-08-09 Thread Konke Radlow
On Thu, Aug 9, 2012 at 11:58 AM, Hans de Goede wrote: > Other then that I've some minor remarks (comments inline), with all those > fixed, this one is could to go. So hopefully the next version can be added > to git master! I'm very happy to hear that :) > > > On 08/07/2012 05:11 PM, Konke Radl

Re: [RFC PATCH 1/2] Add libv4l2rds library (with changes proposed in RFC)

2012-08-09 Thread Konke Radlow
they are gone. And btw: I'm sorry for fiddling with your build environment in such a way. I have to admit that the additions I made were based more on copying from existing libraries than really understanding the effects of each command. Regards, Konke On Thu, Aug 9, 2012 at 7:22 AM, Gregor Jasn

Re: [RFC PATCH 1/2] Add libv4l2rds library (with changes proposed in RFC)

2012-08-09 Thread Hans Verkuil
On Tue August 7 2012 17:11:54 Konke Radlow wrote: > --- > Makefile.am |3 +- > configure.ac|7 +- > lib/include/libv4l2rds.h| 228 ++ > lib/libv4l2rds/Makefile.am | 11 + > lib/libv4l2rds/libv4l2rds.c | 953 > +++

Re: [RFC PATCH 1/2] Add libv4l2rds library (with changes proposed in RFC)

2012-08-09 Thread Hans Verkuil
On Thu August 9 2012 13:58:07 Hans de Goede wrote: > Hi Konke, > > As Gregor already mentioned there is no need to define libv4l2rdssubdir in > configure.ac , > so please drop that. > > Other then that I've some minor remarks (comments inline), with all those > fixed, this one is could to go. So

Re: [RFC PATCH 1/2] Add libv4l2rds library (with changes proposed in RFC)

2012-08-09 Thread Hans de Goede
Hi Konke, As Gregor already mentioned there is no need to define libv4l2rdssubdir in configure.ac , so please drop that. Other then that I've some minor remarks (comments inline), with all those fixed, this one is could to go. So hopefully the next version can be added to git master! On 08/07/

Re: [RFC PATCH 1/2] Add libv4l2rds library (with changes proposed in RFC)

2012-08-09 Thread Gregor Jasny
Hello Konke, On 8/7/12 5:11 PM, Konke Radlow wrote: diff --git a/configure.ac b/configure.ac index 8ddcc9d..1109c4d 100644 --- a/configure.ac +++ b/configure.ac @@ -146,9 +148,12 @@ AC_ARG_WITH(libv4l2subdir, AS_HELP_STRING(--with-libv4l2subdir=DIR,set libv4l2 l AC_ARG_WITH(libv4lconvertsubdi

[RFC PATCH 1/2] Add libv4l2rds library (with changes proposed in RFC)

2012-08-07 Thread Konke Radlow
--- Makefile.am |3 +- configure.ac|7 +- lib/include/libv4l2rds.h| 228 ++ lib/libv4l2rds/Makefile.am | 11 + lib/libv4l2rds/libv4l2rds.c | 953 +++ lib/libv4l2rds/libv4l2rds.pc.in |