Re: [RFC PATCH] fixp-arith: replace sin/cos table by a better precision one

2014-12-17 Thread Prashant Laddha (prladdha)
Thanks for the patch, Mauro. Just a correction below. > >+/* cos(x) = sin(x + pi radians) */ >+ This should pi / 2. Correcting for the same below. >+#define fixp_cos32_rad(rad, twopi)\ >+ fixp_sin32_rad(rad + twopi/2, twopi) fixp_sin32_rad(rad + twopi/4, twopi) >+ I think t

[RFC PATCH] fixp-arith: replace sin/cos table by a better precision one

2014-12-16 Thread Mauro Carvalho Chehab
The cos table used at fixp-arith.h has only 8 bits of precision. That causes problems if it is reused on other drivers. As some media drivers require a higher precision sin/cos implementation, replace the current implementation by one that will provide 32 bits precision. The values generated by t