Re: [RFC 4/8] omap3isp: Rework OF endpoint parsing

2019-04-04 Thread Sakari Ailus
Hi Hans, Thank you for reviewing this. On Thu, Apr 04, 2019 at 03:43:51PM +0200, Hans Verkuil wrote: > On 3/18/19 8:16 PM, Sakari Ailus wrote: ... > > +static int isp_parse_of_endpoints(struct isp_device *isp) > > +{ > > + struct fwnode_handle *ep; > > + struct isp_async_subdev *isd; > > +

Re: [RFC 4/8] omap3isp: Rework OF endpoint parsing

2019-04-04 Thread Hans Verkuil
On 3/18/19 8:16 PM, Sakari Ailus wrote: > Rework OF endpoint parsing for the omap3isp driver. This does add some > lines of code. The benefits are still clear: > > - the great complication related to callbacks in endpoint parsing is gone; > instead endpoints are obtained port by port and > > -

[RFC 4/8] omap3isp: Rework OF endpoint parsing

2019-03-18 Thread Sakari Ailus
Rework OF endpoint parsing for the omap3isp driver. This does add some lines of code. The benefits are still clear: - the great complication related to callbacks in endpoint parsing is gone; instead endpoints are obtained port by port and - endpoints may now have a default bus configuration whi