Hi Sylwester,
Thanks for the review!
Sylwester Nawrocki wrote:
> On 12/20/2011 09:28 PM, Sakari Ailus wrote:
>> +
>> +static int rm680_sec_camera_set_xshutdown(struct v4l2_subdev *subdev,
>> u8 set)
>
> It may be more efficient to just use u32.
The function got removed already. ;-)
>> +{
>> +
Hi Laurent,
Thanks for the review!
Laurent Pinchart wrote:
> On Tuesday 20 December 2011 21:28:09 Sakari Ailus wrote:
>> This currently introduces an extra file to the arch/arm/mach-omap2
>> directory: board-rm680-camera.c. Keeping the device tree in mind, the
>> context of the file could be repr
Hi Sakari,
On 12/20/2011 09:28 PM, Sakari Ailus wrote:
+
+static int rm680_sec_camera_set_xshutdown(struct v4l2_subdev *subdev, u8 set)
It may be more efficient to just use u32.
+{
+ gpio_set_value(SEC_CAMERA_RESET_GPIO, !!set);
+ return 0;
+}
+
...
+void __init rm680_camera_in
Hi Sakari,
Thanks for the patch.
On Tuesday 20 December 2011 21:28:09 Sakari Ailus wrote:
> This currently introduces an extra file to the arch/arm/mach-omap2
> directory: board-rm680-camera.c. Keeping the device tree in mind, the
> context of the file could be represented as static data with one
This currently introduces an extra file to the arch/arm/mach-omap2
directory: board-rm680-camera.c. Keeping the device tree in mind, the
context of the file could be represented as static data with one exception:
the external clock to the sensor.
This external clock is provided by the OMAP 3 SoC a
