Re: [RFC 16/17] smiapp: Add driver.

2012-01-16 Thread Sylwester Nawrocki
Hi Sakari, On 01/08/2012 12:01 AM, Sakari Ailus wrote: >>> +/* >>> + * >>> + * V4L2 Controls handling >>> + * >>> + */ >>> + >>> +static void __smiapp_update_exposure_limits(struct smiapp_sensor *sensor) >>> +{ >>> + struct v4l2_ctrl *ctrl = sensor->exposure; >>> + int max; >>> + >>> + max =

Re: [RFC 16/17] smiapp: Add driver.

2012-01-07 Thread Sakari Ailus
Hi Sylwester, Thanks for the review!!! Sylwester Nawrocki wrote: > Hi Sakari, > > I have a just a few comments below. It was rather brief a review, given the > size of the patch.. :-) Good points. I'll make the changes, as well as those Laurent pointed out, and send a new version of the driver.

Re: [RFC 16/17] smiapp: Add driver.

2012-01-06 Thread Sylwester Nawrocki
Hi Sakari, I have a just a few comments below. It was rather brief a review, given the size of the patch.. :-) On 12/20/2011 09:28 PM, Sakari Ailus wrote: > Add driver for SMIA++/SMIA image sensors. The driver exposes the sensor as > three subdevs, pixel array, binner and scaler --- in case the d