Re: [RFC 13/17] omap3isp: Configure CSI-2 phy based on platform data

2012-01-11 Thread Sakari Ailus
Hi Sylwester, Sylwester Nawrocki wrote: > On 01/08/2012 12:16 PM, Sakari Ailus wrote: >>> Shouldn't lane configuration be retrieved from the sensor instead ? >>> Sensors could use different lane configuration depending on the mode. >>> This could also be implemented later when needed,

Re: [RFC 13/17] omap3isp: Configure CSI-2 phy based on platform data

2012-01-08 Thread Sylwester Nawrocki
Hi Sakari, On 01/08/2012 12:16 PM, Sakari Ailus wrote: >> Shouldn't lane configuration be retrieved from the sensor instead ? >> Sensors could use different lane configuration depending on the mode. >> This could also be implemented later when needed, but I don't think it >> would

Re: [RFC 13/17] omap3isp: Configure CSI-2 phy based on platform data

2012-01-08 Thread Sakari Ailus
Hi Sylwester, Sylwester Nawrocki wrote: > Hi, > > On 01/08/2012 11:26 AM, Sakari Ailus wrote: > Shouldn't lane configuration be retrieved from the sensor instead ? > Sensors could use different lane configuration depending on the mode. > This could also be implemented later when neede

Re: [RFC 13/17] omap3isp: Configure CSI-2 phy based on platform data

2012-01-08 Thread Laurent Pinchart
Hi Sakari, On Sunday 08 January 2012 11:26:02 Sakari Ailus wrote: > Laurent Pinchart wrote: > > On Saturday 07 January 2012 23:51:24 Sakari Ailus wrote: > >> Laurent Pinchart wrote: > >>> On Tuesday 20 December 2011 21:28:05 Sakari Ailus wrote: > From: Sakari Ailus > > Configure C

Re: [RFC 13/17] omap3isp: Configure CSI-2 phy based on platform data

2012-01-08 Thread Sylwester Nawrocki
Hi, On 01/08/2012 11:26 AM, Sakari Ailus wrote: Shouldn't lane configuration be retrieved from the sensor instead ? Sensors could use different lane configuration depending on the mode. This could also be implemented later when needed, but I don't think it would be too difficul

Re: [RFC 13/17] omap3isp: Configure CSI-2 phy based on platform data

2012-01-08 Thread Sakari Ailus
Hi Laurent, Laurent Pinchart wrote: > Hi Sakari, > > On Saturday 07 January 2012 23:51:24 Sakari Ailus wrote: >> Laurent Pinchart wrote: >>> On Tuesday 20 December 2011 21:28:05 Sakari Ailus wrote: From: Sakari Ailus Configure CSI-2 phy based on platform data in the ISP driver rat

Re: [RFC 13/17] omap3isp: Configure CSI-2 phy based on platform data

2012-01-07 Thread Laurent Pinchart
Hi Sakari, On Saturday 07 January 2012 23:51:24 Sakari Ailus wrote: > Laurent Pinchart wrote: > > On Tuesday 20 December 2011 21:28:05 Sakari Ailus wrote: > >> From: Sakari Ailus > >> > >> Configure CSI-2 phy based on platform data in the ISP driver rather than > >> in platform code. > >> > >>

Re: [RFC 13/17] omap3isp: Configure CSI-2 phy based on platform data

2012-01-07 Thread Sakari Ailus
Hi Laurent, Thanks for the review!!! Laurent Pinchart wrote: > On Tuesday 20 December 2011 21:28:05 Sakari Ailus wrote: >> From: Sakari Ailus >> >> Configure CSI-2 phy based on platform data in the ISP driver rather than in >> platform code. >> >> Signed-off-by: Sakari Ailus >> --- >> drivers/

Re: [RFC 13/17] omap3isp: Configure CSI-2 phy based on platform data

2012-01-06 Thread Laurent Pinchart
Hi Sakari, Thanks for the patch. On Tuesday 20 December 2011 21:28:05 Sakari Ailus wrote: > From: Sakari Ailus > > Configure CSI-2 phy based on platform data in the ISP driver rather than in > platform code. > > Signed-off-by: Sakari Ailus > --- > drivers/media/video/omap3isp/isp.c |

[RFC 13/17] omap3isp: Configure CSI-2 phy based on platform data

2011-12-20 Thread Sakari Ailus
From: Sakari Ailus Configure CSI-2 phy based on platform data in the ISP driver rather than in platform code. Signed-off-by: Sakari Ailus --- drivers/media/video/omap3isp/isp.c | 38 -- drivers/media/video/omap3isp/isp.h |3 - drivers/media/video/omap3isp/ispcsiph