Re: [RFC 1/3] saa7115: Set saa7113 init to values from datasheet

2013-05-31 Thread Jon Arne Jørgensen
On Fri, May 31, 2013 at 10:08:27AM -0300, Mauro Carvalho Chehab wrote: > Em Thu, 30 May 2013 21:00:01 +0200 > Jon Arne Jørgensen escreveu: > > > On Thu, May 30, 2013 at 08:33:32AM +0300, Timo Teras wrote: > > > On Thu, 30 May 2013 07:21:36 +0200 > > > Jon Arne Jørgensen wrote: > > > > > > > On

Re: [RFC 1/3] saa7115: Set saa7113 init to values from datasheet

2013-05-31 Thread Timo Teras
On Fri, 31 May 2013 10:08:27 -0300 Mauro Carvalho Chehab wrote: > Em Thu, 30 May 2013 21:00:01 +0200 > Jon Arne Jørgensen escreveu: > > > On Thu, May 30, 2013 at 08:33:32AM +0300, Timo Teras wrote: > > > I would rather have the platform_data provide the new table. Or > > > if you think bulk of

Re: [RFC 1/3] saa7115: Set saa7113 init to values from datasheet

2013-05-31 Thread Mauro Carvalho Chehab
Em Thu, 30 May 2013 21:00:01 +0200 Jon Arne Jørgensen escreveu: > On Thu, May 30, 2013 at 08:33:32AM +0300, Timo Teras wrote: > > On Thu, 30 May 2013 07:21:36 +0200 > > Jon Arne Jørgensen wrote: > > > > > On Wed, May 29, 2013 at 10:19:49PM -0400, Andy Walls wrote: > > > > Mauro Carvalho Chehab

Re: [RFC 1/3] saa7115: Set saa7113 init to values from datasheet

2013-05-30 Thread Jon Arne Jørgensen
On Thu, May 30, 2013 at 08:33:32AM +0300, Timo Teras wrote: > On Thu, 30 May 2013 07:21:36 +0200 > Jon Arne Jørgensen wrote: > > > On Wed, May 29, 2013 at 10:19:49PM -0400, Andy Walls wrote: > > > Mauro Carvalho Chehab wrote: > > > > > > >Em Wed, 29 May 2013 22:41:16 +0200 > > > >Jon Arne Jørge

Re: [RFC 1/3] saa7115: Set saa7113 init to values from datasheet

2013-05-29 Thread Timo Teras
On Thu, 30 May 2013 07:21:36 +0200 Jon Arne Jørgensen wrote: > On Wed, May 29, 2013 at 10:19:49PM -0400, Andy Walls wrote: > > Mauro Carvalho Chehab wrote: > > > > >Em Wed, 29 May 2013 22:41:16 +0200 > > >Jon Arne Jørgensen escreveu: > > > > > >> Change all default values in the initial setup

Re: [RFC 1/3] saa7115: Set saa7113 init to values from datasheet

2013-05-29 Thread Jon Arne Jørgensen
On Wed, May 29, 2013 at 10:19:49PM -0400, Andy Walls wrote: > Mauro Carvalho Chehab wrote: > > >Em Wed, 29 May 2013 22:41:16 +0200 > >Jon Arne Jørgensen escreveu: > > > >> Change all default values in the initial setup table to match the > >table > >> in the datasheet. > > > >This is not a good

Re: [RFC 1/3] saa7115: Set saa7113 init to values from datasheet

2013-05-29 Thread Andy Walls
Mauro Carvalho Chehab wrote: >Em Wed, 29 May 2013 22:41:16 +0200 >Jon Arne Jørgensen escreveu: > >> Change all default values in the initial setup table to match the >table >> in the datasheet. > >This is not a good idea, as it can produce undesired side effects >on the existing drivers that dep

Re: [RFC 1/3] saa7115: Set saa7113 init to values from datasheet

2013-05-29 Thread Mauro Carvalho Chehab
Em Wed, 29 May 2013 22:41:16 +0200 Jon Arne Jørgensen escreveu: > Change all default values in the initial setup table to match the table > in the datasheet. This is not a good idea, as it can produce undesired side effects on the existing drivers that depend on it, and can't be easily tested.

[RFC 1/3] saa7115: Set saa7113 init to values from datasheet

2013-05-29 Thread Jon Arne Jørgensen
Change all default values in the initial setup table to match the table in the datasheet. Signed-off-by: Jon Arne Jørgensen --- drivers/media/i2c/saa7115.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/media/i2c/saa7115.c b/drivers/media/i2c/saa7115.c i