Re: [RFC 04/17] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

2012-01-07 Thread Sakari Ailus
Laurent Pinchart wrote: > Hi Sakari, > > On Saturday 07 January 2012 12:09:29 Sakari Ailus wrote: >> Sakari Ailus wrote: >> ... >> >>> On second thought, I think I'll combine them into a new anonymous struct >>> the field name of which I call "pad", unless that requires too intrusive >>> changes i

Re: [RFC 04/17] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

2012-01-07 Thread Laurent Pinchart
Hi Sakari, On Saturday 07 January 2012 12:09:29 Sakari Ailus wrote: > Sakari Ailus wrote: > ... > > > On second thought, I think I'll combine them into a new anonymous struct > > the field name of which I call "pad", unless that requires too intrusive > > changes in other drivers. How about that?

Re: [RFC 04/17] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

2012-01-07 Thread Sakari Ailus
Sakari Ailus wrote: ... > On second thought, I think I'll combine them into a new anonymous struct > the field name of which I call "pad", unless that requires too intrusive > changes in other drivers. How about that? And the answer to that is "no". The smia++ driver does store the format, crop an

Re: [RFC 04/17] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

2012-01-07 Thread Sakari Ailus
Hi Laurent, Laurent Pinchart wrote: > Hi Sakari, > > On Friday 06 January 2012 12:27:03 Sakari Ailus wrote: >> Laurent Pinchart wrote: >>> On Tuesday 20 December 2011 21:27:56 Sakari Ailus wrote: From: Sakari Ailus Add support for VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELE

Re: [RFC 04/17] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

2012-01-06 Thread Laurent Pinchart
Hi Sakari, On Friday 06 January 2012 12:27:03 Sakari Ailus wrote: > Laurent Pinchart wrote: > > On Tuesday 20 December 2011 21:27:56 Sakari Ailus wrote: > >> From: Sakari Ailus > >> > >> Add support for VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION > >> IOCTLs. They replace functionali

Re: [RFC 04/17] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

2012-01-06 Thread Sakari Ailus
Hi Laurent, Thanks for the comments! Laurent Pinchart wrote: > On Tuesday 20 December 2011 21:27:56 Sakari Ailus wrote: >> From: Sakari Ailus >> >> Add support for VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION >> IOCTLs. They replace functionality provided by VIDIOC_SUBDEV_S_CROP and >

Re: [RFC 04/17] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

2012-01-05 Thread Laurent Pinchart
Hi Sakari, Thanks for the patch. On Tuesday 20 December 2011 21:27:56 Sakari Ailus wrote: > From: Sakari Ailus > > Add support for VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION > IOCTLs. They replace functionality provided by VIDIOC_SUBDEV_S_CROP and > VIDIOC_SUBDEV_G_CROP IOCTLs and

[RFC 04/17] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

2011-12-20 Thread Sakari Ailus
From: Sakari Ailus Add support for VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs. They replace functionality provided by VIDIOC_SUBDEV_S_CROP and VIDIOC_SUBDEV_G_CROP IOCTLs and also add new functionality (composing). VIDIOC_SUBDEV_G_CROP and VIDIOC_SUBDEV_S_CROP continue to be