Re: [RFC] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-07 Thread Andy Walls
On Wed, 2010-04-07 at 13:42 +0200, David Härdeman wrote: > On Wed, Apr 07, 2010 at 06:20:07AM -0400, Andy Walls wrote: > > On Tue, 2010-04-06 at 11:26 -0300, Mauro Carvalho Chehab wrote: > > > I won't comment every single bits of the change, since we're more > > > interested on the conceptual > >

Re: [RFC] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-07 Thread Jon Smirl
On Wed, Apr 7, 2010 at 9:29 AM, Mauro Carvalho Chehab wrote: > On the implementation I did, each event is passed to each decoder serialized > (yet, as one keystroke > is a series of events, it behaves as if they are processed in parallel). We > might create separate > kthreads for each decoder,

Re: [RFC] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-07 Thread Mauro Carvalho Chehab
Jon Smirl wrote: > I had to rework this portion of code several times in the IR code I posted. > > I had the core provide input_ir_queue() which was legal to call from > interrupt context. Calling from interrupt context was an important > aspect I missed in the first versions. I made this a common

Re: [RFC] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-07 Thread Mauro Carvalho Chehab
David Härdeman wrote: > On Tue, Apr 06, 2010 at 11:26:35AM -0300, Mauro Carvalho Chehab wrote: >> Hi David, >> >> Em Tue, 6 Apr 2010 12:48:11 +0200 >> David Härdeman escreveu: >> >>> Content-Type: text/plain; charset=us-ascii >>> Content-Disposition: inline; filename=use-pulse-space-timings-in-ir-

Re: [RFC] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-07 Thread Jon Smirl
I had to rework this portion of code several times in the IR code I posted. I had the core provide input_ir_queue() which was legal to call from interrupt context. Calling from interrupt context was an important aspect I missed in the first versions. I made this a common routine so that the code d

Re: [RFC] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-07 Thread David Härdeman
On Wed, Apr 07, 2010 at 06:20:07AM -0400, Andy Walls wrote: > On Tue, 2010-04-06 at 11:26 -0300, Mauro Carvalho Chehab wrote: > > I won't comment every single bits of the change, since we're more > > interested on the conceptual > > aspects. > > > > > -int ir_raw_event_store(struct input_dev *inp

Re: [RFC] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-07 Thread David Härdeman
On Tue, Apr 06, 2010 at 11:26:35AM -0300, Mauro Carvalho Chehab wrote: > Hi David, > > Em Tue, 6 Apr 2010 12:48:11 +0200 > David Härdeman escreveu: > > > Content-Type: text/plain; charset=us-ascii > > Content-Disposition: inline; filename=use-pulse-space-timings-in-ir-raw > > Thunderbird 2 real

Re: [RFC] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-07 Thread Andy Walls
On Tue, 2010-04-06 at 11:26 -0300, Mauro Carvalho Chehab wrote: > Hi David, > > I won't comment every single bits of the change, since we're more interested > on the conceptual > aspects. > > > -int ir_raw_event_store(struct input_dev *input_dev, enum raw_event_type > > type) > > Don't remove

Re: [RFC] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-06 Thread Mauro Carvalho Chehab
Hi David, Em Tue, 6 Apr 2010 12:48:11 +0200 David Härdeman escreveu: > Content-Type: text/plain; charset=us-ascii > Content-Disposition: inline; filename=use-pulse-space-timings-in-ir-raw Thunderbird 2 really don't like this. It considers the entire body as a file, and refuses to quote it. >

[RFC] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-06 Thread David Härdeman
drivers/media/IR/ir-raw-event.c is currently written with the assumption that all "raw" hardware will generate events only on state change (i.e. when a pulse or space starts). However, some hardware (like mceusb, probably the most popular IR receiver out there) only generates duration data (and th