Re: [RFC] Need testers for s5h1409 tuning fix

2009-01-23 Thread Andy Walls
On Fri, 2009-01-23 at 22:07 -0500, A. F. Cano wrote: > On Fri, Jan 23, 2009 at 08:31:18PM -0500, Andy Walls wrote: > > ... > > Since I was to lazy to get Kaffeine to work properly, I wrote my own > > test app. It is inline below so you can see how I measured the time. > > As I pointed out in anot

Re: [RFC] Need testers for s5h1409 tuning fix

2009-01-23 Thread Andy Walls
On Fri, 2009-01-23 at 21:50 -0500, Devin Heitmueller wrote: > On Fri, Jan 23, 2009 at 8:31 PM, Andy Walls wrote: > > For OTA ATSC 8-VSB with an HVR-1600 MCE: > > > > Without the change: > > > > $ ./tune > > Commanding tune to freq 479028615 ... FE_HAS_LOCK in 1.416984 seconds. > > Commanding tune

Re: [RFC] Need testers for s5h1409 tuning fix

2009-01-23 Thread A. F. Cano
On Fri, Jan 23, 2009 at 08:31:18PM -0500, Andy Walls wrote: > ... > Since I was to lazy to get Kaffeine to work properly, I wrote my own > test app. It is inline below so you can see how I measured the time. As I pointed out in another message recently I've been having problems tuning my own pvru

Re: [RFC] Need testers for s5h1409 tuning fix

2009-01-23 Thread Devin Heitmueller
On Fri, Jan 23, 2009 at 8:31 PM, Andy Walls wrote: > For OTA ATSC 8-VSB with an HVR-1600 MCE: > > Without the change: > > $ ./tune > Commanding tune to freq 479028615 ... FE_HAS_LOCK in 1.416984 seconds. > Commanding tune to freq 551028615 ... FE_HAS_LOCK in 1.389922 seconds. > Commanding tune to

Re: [RFC] Need testers for s5h1409 tuning fix

2009-01-23 Thread Andy Walls
On Fri, 2009-01-23 at 14:36 -0500, Devin Heitmueller wrote: > > It would be good if you could provide some actual data regarding > before and after the patch. Typically I run Kaffeine from the command > line, which prints out the tuning time to stdout. For example, here > are the times Robert s

Re: [RFC] Need testers for s5h1409 tuning fix

2009-01-23 Thread Andy Walls
On Fri, 2009-01-23 at 14:36 -0500, Devin Heitmueller wrote: > On Fri, Jan 23, 2009 at 1:05 PM, Andy Walls wrote: > > Holy cow! the thing tunes fast now! > > > > One burst error I received seemed much more devasting to mplayer's > > decoder than it usually does though. (I guess fast tuning or relo

Re: [RFC] Need testers for s5h1409 tuning fix

2009-01-23 Thread Devin Heitmueller
On Fri, Jan 23, 2009 at 1:05 PM, Andy Walls wrote: > Holy cow! the thing tunes fast now! > > One burst error I received seemed much more devasting to mplayer's > decoder than it usually does though. (I guess fast tuning or relocking > may have it's disadvantages, but decoding errant streams as sa

Re: [RFC] Need testers for s5h1409 tuning fix

2009-01-23 Thread Devin Heitmueller
On Fri, Jan 23, 2009 at 12:48 PM, Andy Walls wrote: > I will test soon, but I do have two comments by inspection. > > 1. The function s5h1409_softreset() is now called 3 times by > s5h1409_set_frontend(): once at entry, once by > s5h1409_enable_modulation(), and once at exit. Surely at least one

Re: [RFC] Need testers for s5h1409 tuning fix

2009-01-23 Thread Andy Walls
On Wed, 2009-01-21 at 23:45 -0500, Devin Heitmueller wrote: > The attached patch significantly improves tuning lock times for all > three s5h1409 based devices I have tested with so far. However, > because of the large number of devices affected, I would like to > solicit people with products that

Re: [RFC] Need testers for s5h1409 tuning fix

2009-01-23 Thread Andy Walls
On Wed, 2009-01-21 at 23:45 -0500, Devin Heitmueller wrote: > The attached patch significantly improves tuning lock times for all > three s5h1409 based devices I have tested with so far. However, > because of the large number of devices affected, I would like to > solicit people with products that

[RFC] Need testers for s5h1409 tuning fix

2009-01-21 Thread Devin Heitmueller
The attached patch significantly improves tuning lock times for all three s5h1409 based devices I have tested with so far. However, because of the large number of devices affected, I would like to solicit people with products that use the s5h1409 to test the patch and report back any problems befo