Re: [REVIEWv2 PATCH 04/19] bttv: remove g/s_audio since there is only one audio input.

2013-02-11 Thread Frank Schäfer
Am 11.02.2013 15:22, schrieb Hans Verkuil: > On Sun February 10 2013 21:22:41 Frank Schäfer wrote: >> Hmm... G/S_AUDIO is also used to query/set the capabilities and the mode >> of an input, which IMHO makes sense even if the input is the only one >> the device has ? > You are right, but there are

Re: [REVIEWv2 PATCH 04/19] bttv: remove g/s_audio since there is only one audio input.

2013-02-11 Thread Hans Verkuil
On Sun February 10 2013 21:22:41 Frank Schäfer wrote: > > Hmm... G/S_AUDIO is also used to query/set the capabilities and the mode > of an input, which IMHO makes sense even if the input is the only one > the device has ? You are right, but there are problems with the implementation in this drive

Re: [REVIEWv2 PATCH 04/19] bttv: remove g/s_audio since there is only one audio input.

2013-02-10 Thread Frank Schäfer
Hmm... G/S_AUDIO is also used to query/set the capabilities and the mode of an input, which IMHO makes sense even if the input is the only one the device has ? Don't you think that it's also somehow inconsistent, because for the video inputs (G/S_INPUT) the spec says: "This ioctl will fail only wh

[REVIEWv2 PATCH 04/19] bttv: remove g/s_audio since there is only one audio input.

2013-02-10 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/pci/bt8xx/bttv-driver.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/drivers/media/pci/bt8xx/bttv-driver.c b/drivers/media/pci/bt8xx/bttv-driver.c index 6e61dbd..a02c031 100644 --- a/drivers/media/pci