Re: [REVIEW PATCH 06/11] vb2: set timestamp when using write()

2014-04-07 Thread Hans Verkuil
On 04/07/2014 10:32 AM, Pawel Osciak wrote: > On Tue, Mar 11, 2014 at 6:20 AM, Hans Verkuil wrote: >> From: Hans Verkuil >> >> When using write() to write data to an output video node the vb2 core >> should set timestamps if V4L2_BUF_FLAG_TIMESTAMP_COPY is set. Nobody > > I'm confused. Shouldn't

Re: [REVIEW PATCH 06/11] vb2: set timestamp when using write()

2014-04-07 Thread Pawel Osciak
On Tue, Mar 11, 2014 at 6:20 AM, Hans Verkuil wrote: > From: Hans Verkuil > > When using write() to write data to an output video node the vb2 core > should set timestamps if V4L2_BUF_FLAG_TIMESTAMP_COPY is set. Nobody I'm confused. Shouldn't we be saving the existing timestamp from the buffer i

[REVIEW PATCH 06/11] vb2: set timestamp when using write()

2014-03-10 Thread Hans Verkuil
From: Hans Verkuil When using write() to write data to an output video node the vb2 core should set timestamps if V4L2_BUF_FLAG_TIMESTAMP_COPY is set. Nobody else is able to provide this information with the write() operation. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/videobuf2-c