Re: [REVIEW PATCH 04/11] vb2: use correct prefix

2014-04-07 Thread Hans Verkuil
On 04/07/2014 09:30 AM, Pawel Osciak wrote: > The idea behind not using __func__ was that it was much more > informative when debugging to see a "reqbufs" prefix instead of, for > example "__verify_memory_type". But since some of the functions are > shared across multiple ioctl impls now (e.g. __ve

Re: [REVIEW PATCH 04/11] vb2: use correct prefix

2014-04-07 Thread Pawel Osciak
The idea behind not using __func__ was that it was much more informative when debugging to see a "reqbufs" prefix instead of, for example "__verify_memory_type". But since some of the functions are shared across multiple ioctl impls now (e.g. __verify_memory_type is used by both reqbufs and createb

[REVIEW PATCH 04/11] vb2: use correct prefix

2014-03-10 Thread Hans Verkuil
From: Hans Verkuil Many dprintk's in vb2 use a hardcoded prefix with the function name. In many cases that is now outdated. Replace prefixes by the function name using __func__. At least now I know if I see a 'qbuf:' prefix whether that refers to the mmap, userptr or dmabuf variant. Signed-off-b