Re: [REVIEW PATCH 0/5] SDR API - Mirics MSi3101 driver

2014-02-14 Thread Hans Verkuil
On 02/14/2014 03:40 PM, Hans Verkuil wrote: > Hi Antti, > > Just one very tiny thing: in patch 1 in msi3101_template you added this line: > > + .debug= 0, > > Please remove. Fields initialized to 0 should in general be dropped since the > compiler sets it to 0 already, an

Re: [REVIEW PATCH 0/5] SDR API - Mirics MSi3101 driver

2014-02-14 Thread Hans Verkuil
Hi Antti, Just one very tiny thing: in patch 1 in msi3101_template you added this line: + .debug= 0, Please remove. Fields initialized to 0 should in general be dropped since the compiler sets it to 0 already, and eventually the debug field will disappear anyway since y

[REVIEW PATCH 0/5] SDR API - Mirics MSi3101 driver

2014-02-10 Thread Antti Palosaari
Split / group / merge changes as requested by Hans. Antti Antti Palosaari (5): msi3101: convert to SDR API msi001: Mirics MSi001 silicon tuner driver msi3101: use msi001 tuner driver MAINTAINERS: add msi001 driver MAINTAINERS: add msi3101 driver MAINTAINERS