Re: [Patch v2 11/11] Documention: v4l: Documentation for HEVC CIDs

2017-03-14 Thread Smitha T Murthy
On Tue, 2017-03-07 at 13:08 +0100, Andrzej Hajda wrote: > On 03.03.2017 10:07, Smitha T Murthy wrote: > > Added V4l2 controls for HEVC encoder > > It should be rather "Document controls for HEVC encoder" or sth similar. > > In general most of comments are in previous patch. > Few additional comm

Re: [Patch v2 11/11] Documention: v4l: Documentation for HEVC CIDs

2017-03-07 Thread Andrzej Hajda
On 03.03.2017 10:07, Smitha T Murthy wrote: > Added V4l2 controls for HEVC encoder It should be rather "Document controls for HEVC encoder" or sth similar. In general most of comments are in previous patch. Few additional comments: - please be careful about control names - they are exported to u

[Patch v2 11/11] Documention: v4l: Documentation for HEVC CIDs

2017-03-03 Thread Smitha T Murthy
Added V4l2 controls for HEVC encoder Signed-off-by: Smitha T Murthy --- Documentation/media/uapi/v4l/extended-controls.rst | 314 1 files changed, 314 insertions(+), 0 deletions(-) diff --git a/Documentation/media/uapi/v4l/extended-controls.rst b/Documentation/media/uapi/