Re: [PULL] nGene driver - http://endr...@linuxtv.org/hg/~endriss/ngene

2010-02-05 Thread Oliver Endriss
Hi, Mauro Carvalho Chehab wrote: > There's just one thing missing: to update the get firmware script to get the > firmware files from somewhere, or to add some documentation about how to > retrieve it. When you have some time, please prepare something. Mauro, Please pull from http://endr...@linu

Re: [PULL] nGene driver - http://endr...@linuxtv.org/hg/~endriss/ngene

2010-02-03 Thread Mauro Carvalho Chehab
Oliver Endriss wrote: > I committed a fix for both I2C issues. > Please pull http://linuxtv.org/hg/~endriss/ngene/rev/d3b4eb4a7bd9 Ok, the major issues were fixed. I'm submitting it to linux-next. There's just one thing missing: to update the get firmware script to get the firmware files from so

Re: [PULL] nGene driver - http://endr...@linuxtv.org/hg/~endriss/ngene

2010-02-03 Thread Oliver Endriss
Hi, Oliver Endriss wrote: > Mauro Carvalho Chehab wrote: > > Oliver Endriss wrote: > > > Mauro Carvalho Chehab wrote: > > >> After applying all the patches, I'm getting this error: > > >> > > >> drivers/media/dvb/ngene/ngene-core.c: In function ‘ngene_i2c_init’: > > >> drivers/media/dvb/ngene/ngen

Re: [PULL] nGene driver - http://endr...@linuxtv.org/hg/~endriss/ngene

2010-02-03 Thread Oliver Endriss
Hi, Mauro Carvalho Chehab wrote: > Oliver Endriss wrote: > > Mauro Carvalho Chehab wrote: > >> Oliver Endriss wrote: > >>> Mauro, > >>> > >>> Please pull from http://endr...@linuxtv.org/hg/~endriss/ngene > >> It were not an easy to work on this changeset, since it hit a bug at > >> gentree.pl scr

Re: [PULL] nGene driver - http://endr...@linuxtv.org/hg/~endriss/ngene

2010-02-03 Thread Mauro Carvalho Chehab
Oliver Endriss wrote: > Hi Mauro, > > Mauro Carvalho Chehab wrote: >> Hi Oliver, >> >> Oliver Endriss wrote: >>> Mauro, >>> >>> Please pull from http://endr...@linuxtv.org/hg/~endriss/ngene >> It were not an easy to work on this changeset, since it hit a bug at >> gentree.pl script. >> Basically,

Re: [PULL] nGene driver - http://endr...@linuxtv.org/hg/~endriss/ngene

2010-02-03 Thread Oliver Endriss
Hi, Mauro Carvalho Chehab wrote: > Mauro Carvalho Chehab wrote: > > Oliver Endriss wrote: > > As usual, after receiving your fixes for the above, I'll review the driver > > manually. > > > > OK, I'm enclosing here the diff file to allow comments. Hard to read. I hope I did not miss an important

Re: [PULL] nGene driver - http://endr...@linuxtv.org/hg/~endriss/ngene

2010-02-03 Thread Helmut Auer
Am 03.02.2010 21:02, schrieb Mauro Carvalho Chehab: > ... > > ERROR: that open brace { should be on the previous line > #1693: FILE: drivers/media/dvb/ngene/ngene-core.c:1615: > + u8 tsin4_config[6] = > + {3072 / 64, 3072 / 64, 0, 3072 / 64, 3072 / 64, 0}; > > ERRO

Re: [PULL] nGene driver - http://endr...@linuxtv.org/hg/~endriss/ngene

2010-02-03 Thread Oliver Endriss
Hi Mauro, Mauro Carvalho Chehab wrote: > Hi Oliver, > > Oliver Endriss wrote: > > Mauro, > > > > Please pull from http://endr...@linuxtv.org/hg/~endriss/ngene > > It were not an easy to work on this changeset, since it hit a bug at > gentree.pl script. > Basically, this drivers use #elseif dir

Re: [PULL] nGene driver - http://endr...@linuxtv.org/hg/~endriss/ngene

2010-02-03 Thread Mauro Carvalho Chehab
Hi Oliver, Oliver Endriss wrote: > Mauro, > > Please pull from http://endr...@linuxtv.org/hg/~endriss/ngene It were not an easy to work on this changeset, since it hit a bug at gentree.pl script. Basically, this drivers use #elseif directive instead of #elif, making gentree.pl to die, and gene

[PULL] nGene driver - http://endr...@linuxtv.org/hg/~endriss/ngene

2010-02-03 Thread Oliver Endriss
Mauro, Please pull from http://endr...@linuxtv.org/hg/~endriss/ngene for the following 20 changesets: 01/20: ngene: Initial check-in http://endr...@linuxtv.org/hg/~endriss/ngene?cmd=changeset;node=643e6259c1e1 02/20: ngene: Driver compiles now http://endr...@linuxtv.org/hg/~endriss/ngene?cmd=ch