On Wed, 18 Mar 2009 11:19:49 -0400
Devin Heitmueller wrote:
> On Wed, Mar 18, 2009 at 11:13 AM, Mauro Carvalho Chehab
> wrote:
> > I'll likely need to move some hunks from one changeset into another, due to
> > au8522: move the analog decoder source file
> > to avoid -git bisect breakages
On Wed, Mar 18, 2009 at 11:13 AM, Mauro Carvalho Chehab
wrote:
> I'll likely need to move some hunks from one changeset into another, due to
> au8522: move the analog decoder source file
> to avoid -git bisect breakages.
No problem. I did put the original move in the same changeset as the
On Sun, 15 Mar 2009 20:30:54 -0400
Devin Heitmueller wrote:
> Hello Mauro,
>
> Please issue a pull request from
> http://linuxtv.org/hg/~dheitmueller/hvr950q-analog2 for the following:
>
> au0828: remove memset calls in v4l2 routines.
> au0828: remove some unneeded braces
> au0828: add entry fo
On Mon, 16 Mar 2009 14:12:19 -0400
Devin Heitmueller wrote:
> On Mon, Mar 16, 2009 at 2:05 PM, Trent Piepho wrote:
> > On Sun, 15 Mar 2009, Devin Heitmueller wrote:
> >> au0828: remove memset calls in v4l2 routines.
> >
> > "The userland callers are responsible for clearing the output buffers, s
On Mon, Mar 16, 2009 at 2:05 PM, Trent Piepho wrote:
> On Sun, 15 Mar 2009, Devin Heitmueller wrote:
>> au0828: remove memset calls in v4l2 routines.
>
> "The userland callers are responsible for clearing the output buffers, so
> remove the unneeded memset calls."
>
> A driver should not assume th
On Sun, 15 Mar 2009, Devin Heitmueller wrote:
> au0828: remove memset calls in v4l2 routines.
"The userland callers are responsible for clearing the output buffers, so
remove the unneeded memset calls."
A driver should not assume that _userspace_ has cleared the buffers. In
some cases userspace
On Mon, Mar 16, 2009 at 3:58 AM, Hans Verkuil wrote:
> Looks great!
>
> I have one small final note (doesn't prevent this from going in):
>
> In au8522_decoder.c you can remove the 'normal_i2c[]' array and
> the I2C_CLIENT_INSMOD macro. It's only relevant for kernels < 2.6.22.
>
> Note that you sh
On Monday 16 March 2009 01:30:54 Devin Heitmueller wrote:
> Hello Mauro,
>
> Please issue a pull request from
> http://linuxtv.org/hg/~dheitmueller/hvr950q-analog2 for the following:
>
> au0828: remove memset calls in v4l2 routines.
> au0828: remove some unneeded braces
> au0828: add entry for un
Hello Mauro,
Please issue a pull request from
http://linuxtv.org/hg/~dheitmueller/hvr950q-analog2 for the following:
au0828: remove memset calls in v4l2 routines.
au0828: remove some unneeded braces
au0828: add entry for undefined input type
au0828/au8522: Codingstyle fixes
au0828: rename macro f
Hello Mauro,
>> The problem is that I check for UNDEFINED so that the .input section
>> of the au0828 board definition can be left uninitialized. Otherwise,
>> I would have to add something like "num_inputs" to the board
>> definition and worry about the value matching the actual number of
>> inp
On Thu, 12 Mar 2009 11:26:15 -0400
Devin Heitmueller wrote:
> On Thu, Mar 12, 2009 at 11:06 AM, Mauro Carvalho Chehab
> wrote:
> >> Yeah, printing "NULL" is bad and I can obviously fix that. The real
> >> reason for the addition of the "UNDEFINED" entry is I use that to
> >> detect if there are
On Thu, 12 Mar 2009 10:11:12 -0400
Devin Heitmueller wrote:
> On Thu, Mar 12, 2009 at 4:54 AM, Mauro Carvalho Chehab
> wrote:
> > Hi Devin,
> >
> > There's a bug on your patch series: see this:
> >
> > Those are the locations of au8522 files at Kernel's tree:
> > drivers/media/dvb/fronten
On Thu, Mar 12, 2009 at 11:06 AM, Mauro Carvalho Chehab
wrote:
>> Yeah, printing "NULL" is bad and I can obviously fix that. The real
>> reason for the addition of the "UNDEFINED" entry is I use that to
>> detect if there are *any* analog inputs defined, which dictates
>> whether the analog subsy
On Thu, 12 Mar 2009 10:24:02 -0400
Devin Heitmueller wrote:
> > hmm.. you are cleaning up f->reserved three times: at v4l2-ioctl, at the
> > memset(f) and at memset(f->reserved).
> >
> > You really wanted to make sure that you've cleaned it, don't you? ;)
>
> Well, I wanted to be *extra* sure.
Hello Mauro,
Thank you for reviewing. See comments inline.
On Thu, Mar 12, 2009 at 6:06 AM, Mauro Carvalho Chehab
wrote:
> +static int vidioc_querycap(struct file *file, void *priv,
> + struct v4l2_capability *cap)
> +{
> + struct au0828_fh *fh = priv;
> +
> On Thu, Mar 12, 2009 at 5:19 AM, Hans Verkuil wrote:
>> Hi Devin,
>>
>> Can you also do the last bit of the v4l2_device/subdev conversion by
>> actually using the subdev callbacks (replace au0828_call_i2c_clients
>> with
>> v4l2_device_call_all), removing attach_inform and detach_inform (alread
On Thu, Mar 12, 2009 at 5:19 AM, Hans Verkuil wrote:
> Hi Devin,
>
> Can you also do the last bit of the v4l2_device/subdev conversion by
> actually using the subdev callbacks (replace au0828_call_i2c_clients with
> v4l2_device_call_all), removing attach_inform and detach_inform (already
> depreca
On Thu, Mar 12, 2009 at 4:54 AM, Mauro Carvalho Chehab
wrote:
> Hi Devin,
>
> There's a bug on your patch series: see this:
>
> Those are the locations of au8522 files at Kernel's tree:
> drivers/media/dvb/frontends/au8522.h
> drivers/media/dvb/frontends/au8522_dig.c
> drivers
> On Thu, Mar 12, 2009 at 5:19 AM, Hans Verkuil wrote:
>>
>>> On Wed, 11 Mar 2009 11:25:20 -0400
>>> Devin Heitmueller wrote:
>>>
Hello Mauro,
Please pull from:
http://linuxtv.org/hg/~dheitmueller/hvr950q-analog2
for the following:
xc5000: fix bug for
On Thu, Mar 12, 2009 at 4:54 AM, Mauro Carvalho Chehab
wrote:
> On Wed, 11 Mar 2009 11:25:20 -0400
> Devin Heitmueller wrote:
>
>> Hello Mauro,
>>
>> Please pull from:
>>
>> http://linuxtv.org/hg/~dheitmueller/hvr950q-analog2
>>
>> for the following:
>>
>> xc5000: fix bug for hybrid xc5000 device
On Thu, Mar 12, 2009 at 5:19 AM, Hans Verkuil wrote:
>
>> On Wed, 11 Mar 2009 11:25:20 -0400
>> Devin Heitmueller wrote:
>>
>>> Hello Mauro,
>>>
>>> Please pull from:
>>>
>>> http://linuxtv.org/hg/~dheitmueller/hvr950q-analog2
>>>
>>> for the following:
>>>
>>> xc5000: fix bug for hybrid xc5000 d
On Wed, 11 Mar 2009 21:00:19 -0400
Devin Heitmueller wrote:
> Hello Mauro,
>
> Please apply one additional patch for the series I sent this morning:
>
> - au0828: make sure v4l2_device name is unique
>
> Thanks,
>
> Devin
>
+static int vidioc_querycap(struct file *file, void *priv,
+
> On Wed, 11 Mar 2009 11:25:20 -0400
> Devin Heitmueller wrote:
>
>> Hello Mauro,
>>
>> Please pull from:
>>
>> http://linuxtv.org/hg/~dheitmueller/hvr950q-analog2
>>
>> for the following:
>>
>> xc5000: fix bug for hybrid xc5000 devices with IF other than 5380
>> au8522: rename the au8522.c sourc
On Wed, 11 Mar 2009 11:25:20 -0400
Devin Heitmueller wrote:
> Hello Mauro,
>
> Please pull from:
>
> http://linuxtv.org/hg/~dheitmueller/hvr950q-analog2
>
> for the following:
>
> xc5000: fix bug for hybrid xc5000 devices with IF other than 5380
> au8522: rename the au8522.c source file
> au8
Hello Mauro,
Please apply one additional patch for the series I sent this morning:
- au0828: make sure v4l2_device name is unique
Thanks,
Devin
--
Devin J. Heitmueller
http://www.devinheitmueller.com
AIM: devinheitmueller
--
To unsubscribe from this list: send the line "unsubscribe linux-medi
On Wed, Mar 11, 2009 at 3:44 PM, Andy Walls wrote:
>
> + /* Create the v4l2_device */
> + snprintf(dev->v4l2_dev.name, sizeof(dev->v4l2_dev.name), "%s-%03d",
> + "au0828", 0);
> + retval = v4l2_device_register(&dev->usbdev->dev, &dev->v4l2_dev);
>
> If you're not g
On Wed, 2009-03-11 at 11:25 -0400, Devin Heitmueller wrote:
> Hello Mauro,
>
> Please pull from:
>
> http://linuxtv.org/hg/~dheitmueller/hvr950q-analog2
>
> for the following:
[snip]
> au0828: Convert to use v4l2_device/subdev framework
+ /* Create the v4l2_device */
+ snprintf(d
Hello Mauro,
Please pull from:
http://linuxtv.org/hg/~dheitmueller/hvr950q-analog2
for the following:
xc5000: fix bug for hybrid xc5000 devices with IF other than 5380
au8522: rename the au8522.c source file
au8522: move shared state and common functions into a separate header files
au8522: fix
28 matches
Mail list logo
