Re: [PATH v3 0/2] Add v4l2 subdev driver for S5K4ECGX sensor with embedded SoC ISP

2012-08-20 Thread Sylwester Nawrocki
Hi Sangwook, On 08/20/2012 12:43 PM, Sangwook Lee wrote: > On 20 August 2012 09:12, Sangwook Lee wrote: >> On 19 August 2012 22:29, Sylwester Nawrocki >> wrote: >>> On 08/03/2012 04:24 PM, Sangwook Lee wrote: I was thinking about this, but this seems to be is a bit time-consuming beca

Re: [PATH v3 0/2] Add v4l2 subdev driver for S5K4ECGX sensor with embedded SoC ISP

2012-08-20 Thread Sangwook Lee
Hi Sylwester On 20 August 2012 09:12, Sangwook Lee wrote: > Hi Sylwester > > On 19 August 2012 22:29, Sylwester Nawrocki > wrote: >> Hi Sangwook, >> >> On 08/03/2012 04:24 PM, Sangwook Lee wrote: >>> I was thinking about this, but this seems to be is a bit time-consuming >>> because >>> I have

Re: [PATH v3 0/2] Add v4l2 subdev driver for S5K4ECGX sensor with embedded SoC ISP

2012-08-20 Thread Sangwook Lee
Hi Sylwester On 19 August 2012 22:29, Sylwester Nawrocki wrote: > Hi Sangwook, > > On 08/03/2012 04:24 PM, Sangwook Lee wrote: >> I was thinking about this, but this seems to be is a bit time-consuming >> because >> I have to do this just due to lack of s5k4ecgx hardware information. >> let me t

Re: [PATH v3 0/2] Add v4l2 subdev driver for S5K4ECGX sensor with embedded SoC ISP

2012-08-19 Thread Sylwester Nawrocki
Hi Sangwook, On 08/03/2012 04:24 PM, Sangwook Lee wrote: > I was thinking about this, but this seems to be is a bit time-consuming > because > I have to do this just due to lack of s5k4ecgx hardware information. > let me try it later once > this patch is accepted. I've converted this driver to u

Re: [PATH v3 0/2] Add v4l2 subdev driver for S5K4ECGX sensor with embedded SoC ISP

2012-08-03 Thread Sylwester Nawrocki
Hi Sangwook, On 08/03/2012 04:24 PM, Sangwook Lee wrote: > Hi Sylwester > > Thank you for the review. > > On 2 August 2012 21:11, Sylwester Nawrocki > wrote: >> On 08/02/2012 03:42 PM, Sangwook Lee wrote: >>> The following 2 patches add driver for S5K4ECGX sensor with embedded ISP >>> SoC, >

Re: [PATH v3 0/2] Add v4l2 subdev driver for S5K4ECGX sensor with embedded SoC ISP

2012-08-03 Thread Sangwook Lee
Hi Sylwester Thank you for the review. On 2 August 2012 21:11, Sylwester Nawrocki wrote: > > Hi Sangwook, > > On 08/02/2012 03:42 PM, Sangwook Lee wrote: > > The following 2 patches add driver for S5K4ECGX sensor with embedded ISP > > SoC, > > and minor v4l2 control API enhancement. S5K4ECGX i

Re: [PATH v3 0/2] Add v4l2 subdev driver for S5K4ECGX sensor with embedded SoC ISP

2012-08-02 Thread Sylwester Nawrocki
Hi Sangwook, On 08/02/2012 03:42 PM, Sangwook Lee wrote: > The following 2 patches add driver for S5K4ECGX sensor with embedded ISP SoC, > and minor v4l2 control API enhancement. S5K4ECGX is 5M CMOS Image sensor from > Samsung > > Changes since v2: > - added GPIO (reset/stby) and regulators > -

[PATH v3 0/2] Add v4l2 subdev driver for S5K4ECGX sensor with embedded SoC ISP

2012-08-02 Thread Sangwook Lee
The following 2 patches add driver for S5K4ECGX sensor with embedded ISP SoC, and minor v4l2 control API enhancement. S5K4ECGX is 5M CMOS Image sensor from Samsung Changes since v2: - added GPIO (reset/stby) and regulators - updated I2C read/write, based on s5k6aa datasheet - fixed set_fmt errors