Re: [PATCHv7 03/15] v4l: vb2: add support for shared buffer (dma_buf)

2012-08-14 Thread Laurent Pinchart
Hi Tomasz, On Thursday 02 August 2012 18:31:13 Tomasz Stanislawski wrote: > On 06/27/2012 10:40 PM, Laurent Pinchart wrote: > > On Tuesday 26 June 2012 13:53:34 Dima Zavin wrote: > >> On Tue, Jun 26, 2012 at 2:40 AM, Hans Verkuil wrote: > >>> On Tue 26 June 2012 11:11:06 Laurent Pinchart wrote: >

Re: [PATCHv7 03/15] v4l: vb2: add support for shared buffer (dma_buf)

2012-08-02 Thread Tomasz Stanislawski
Hi Laurent, Hi Dima, On 06/27/2012 10:40 PM, Laurent Pinchart wrote: > Hi Dima, > > On Tuesday 26 June 2012 13:53:34 Dima Zavin wrote: >> On Tue, Jun 26, 2012 at 2:40 AM, Hans Verkuil wrote: >>> On Tue 26 June 2012 11:11:06 Laurent Pinchart wrote: On Tuesday 26 June 2012 10:40:44 Tomasz Sta

Re: [PATCHv7 03/15] v4l: vb2: add support for shared buffer (dma_buf)

2012-06-27 Thread Laurent Pinchart
Hi Dima, On Tuesday 26 June 2012 13:53:34 Dima Zavin wrote: > On Tue, Jun 26, 2012 at 2:40 AM, Hans Verkuil wrote: > > On Tue 26 June 2012 11:11:06 Laurent Pinchart wrote: > >> On Tuesday 26 June 2012 10:40:44 Tomasz Stanislawski wrote: > >> > Hi Dima Zavin, > >> > Thank you for the patch and for

Re: [PATCHv7 03/15] v4l: vb2: add support for shared buffer (dma_buf)

2012-06-26 Thread Dima Zavin
Hans and Laurent, Thanks for the feedback. On Tue, Jun 26, 2012 at 2:40 AM, Hans Verkuil wrote: > On Tue 26 June 2012 11:11:06 Laurent Pinchart wrote: >> Hi Dima and Tomasz, >> >> Sorry for the late reply. >> >> On Tuesday 26 June 2012 10:40:44 Tomasz Stanislawski wrote: >> > Hi Dima Zavin, >> >

Re: [PATCHv7 03/15] v4l: vb2: add support for shared buffer (dma_buf)

2012-06-26 Thread Dima Zavin
On Tue, Jun 26, 2012 at 1:40 AM, Tomasz Stanislawski wrote: > Hi Dima Zavin, > Thank you for the patch and for a ping remainder :). > > You are right. The unmap is missing in __vb2_queue_cancel. > I will apply your fix into next version of V4L2 support for dmabuf. > > Please refer to some comments

Re: [PATCHv7 03/15] v4l: vb2: add support for shared buffer (dma_buf)

2012-06-26 Thread Hans Verkuil
On Tue 26 June 2012 11:11:06 Laurent Pinchart wrote: > Hi Dima and Tomasz, > > Sorry for the late reply. > > On Tuesday 26 June 2012 10:40:44 Tomasz Stanislawski wrote: > > Hi Dima Zavin, > > Thank you for the patch and for a ping remainder :). > > > > You are right. The unmap is missing in __vb

Re: [PATCHv7 03/15] v4l: vb2: add support for shared buffer (dma_buf)

2012-06-26 Thread Laurent Pinchart
Hi Dima and Tomasz, Sorry for the late reply. On Tuesday 26 June 2012 10:40:44 Tomasz Stanislawski wrote: > Hi Dima Zavin, > Thank you for the patch and for a ping remainder :). > > You are right. The unmap is missing in __vb2_queue_cancel. > I will apply your fix into next version of V4L2 suppo

Re: [PATCHv7 03/15] v4l: vb2: add support for shared buffer (dma_buf)

2012-06-26 Thread Tomasz Stanislawski
Hi Dima Zavin, Thank you for the patch and for a ping remainder :). You are right. The unmap is missing in __vb2_queue_cancel. I will apply your fix into next version of V4L2 support for dmabuf. Please refer to some comments below. On 06/20/2012 08:12 AM, Dima Zavin wrote: > Tomasz, > > I've en

Re: [PATCHv7 03/15] v4l: vb2: add support for shared buffer (dma_buf)

2012-06-19 Thread Dima Zavin
Tomasz, I've encountered an issue with this patch when userspace does several stream_on/stream_off cycles. When the user tries to qbuf a buffer after doing stream_off, we trigger the "dmabuf already pinned" warning since we didn't unmap the buffer as dqbuf was never called. The below patch adds c

[PATCHv7 03/15] v4l: vb2: add support for shared buffer (dma_buf)

2012-06-14 Thread Tomasz Stanislawski
From: Sumit Semwal This patch adds support for DMABUF memory type in videobuf2. It calls relevant APIs of dma_buf for v4l reqbuf / qbuf / dqbuf operations. For this version, the support is for videobuf2 as a user of the shared buffer; so the allocation of the buffer is done outside of V4L2. [A s