Re: [PATCHv5 1 of 8] v4l2_subdev i2c: Add v4l2_i2c_new_subdev_board i2c helper function

2009-06-08 Thread Eduardo Valentin
On Mon, Jun 08, 2009 at 08:38:32AM +0200, ext Hans Verkuil wrote: > On Monday 08 June 2009 08:11:32 Eduardo Valentin wrote: > > Hi guys, > > > > On Mon, Jun 08, 2009 at 05:19:22AM +0200, ext Douglas Schilling Landgraf > wrote: > > > Hi, > > > > > > On Sun, 7 Jun 2009 22:29:14 -0300 > > > > > > Mau

Re: [PATCHv5 1 of 8] v4l2_subdev i2c: Add v4l2_i2c_new_subdev_board i2c helper function

2009-06-07 Thread Hans Verkuil
On Monday 08 June 2009 08:11:32 Eduardo Valentin wrote: > Hi guys, > > On Mon, Jun 08, 2009 at 05:19:22AM +0200, ext Douglas Schilling Landgraf wrote: > > Hi, > > > > On Sun, 7 Jun 2009 22:29:14 -0300 > > > > Mauro Carvalho Chehab wrote: > > > Em Sun, 7 Jun 2009 08:40:08 +0200 > > > > > > Hans Ve

Re: [PATCHv5 1 of 8] v4l2_subdev i2c: Add v4l2_i2c_new_subdev_board i2c helper function

2009-06-07 Thread Hans Verkuil
On Monday 08 June 2009 03:29:14 Mauro Carvalho Chehab wrote: > Em Sun, 7 Jun 2009 08:40:08 +0200 > > Hans Verkuil escreveu: > > On Saturday 06 June 2009 22:40:21 Eduardo Valentin wrote: > > > Hi Hans, > > > > > > On Sat, Jun 6, 2009 at 8:09 PM, Hans Verkuil wrote: > > > > On Saturday 06 June 200

Re: [PATCHv5 1 of 8] v4l2_subdev i2c: Add v4l2_i2c_new_subdev_board i2c helper function

2009-06-07 Thread Eduardo Valentin
Hi guys, On Mon, Jun 08, 2009 at 05:19:22AM +0200, ext Douglas Schilling Landgraf wrote: > Hi, > > On Sun, 7 Jun 2009 22:29:14 -0300 > Mauro Carvalho Chehab wrote: > > > Em Sun, 7 Jun 2009 08:40:08 +0200 > > Hans Verkuil escreveu: > > > > > On Saturday 06 June 2009 22:40:21 Eduardo Valentin w

Re: [PATCHv5 1 of 8] v4l2_subdev i2c: Add v4l2_i2c_new_subdev_board i2c helper function

2009-06-07 Thread Douglas Schilling Landgraf
Hi, On Sun, 7 Jun 2009 22:29:14 -0300 Mauro Carvalho Chehab wrote: > Em Sun, 7 Jun 2009 08:40:08 +0200 > Hans Verkuil escreveu: > > > On Saturday 06 June 2009 22:40:21 Eduardo Valentin wrote: > > > Hi Hans, > > > > > > On Sat, Jun 6, 2009 at 8:09 PM, Hans Verkuil > > > wrote: > > > > On Satur

Re: [PATCHv5 1 of 8] v4l2_subdev i2c: Add v4l2_i2c_new_subdev_board i2c helper function

2009-06-07 Thread Mauro Carvalho Chehab
Em Sun, 7 Jun 2009 08:40:08 +0200 Hans Verkuil escreveu: > On Saturday 06 June 2009 22:40:21 Eduardo Valentin wrote: > > Hi Hans, > > > > On Sat, Jun 6, 2009 at 8:09 PM, Hans Verkuil wrote: > > > On Saturday 06 June 2009 14:49:46 Hans Verkuil wrote: > > > > On Saturday 06 June 2009 13:59:19 Hans

Re: [PATCHv5 1 of 8] v4l2_subdev i2c: Add v4l2_i2c_new_subdev_board i2c helper function

2009-06-06 Thread Hans Verkuil
On Saturday 06 June 2009 22:40:21 Eduardo Valentin wrote: > Hi Hans, > > On Sat, Jun 6, 2009 at 8:09 PM, Hans Verkuil wrote: > > On Saturday 06 June 2009 14:49:46 Hans Verkuil wrote: > > > On Saturday 06 June 2009 13:59:19 Hans Verkuil wrote: > > > > On Friday 29 May 2009 09:33:21 Eduardo Valentin

Re: [PATCHv5 1 of 8] v4l2_subdev i2c: Add v4l2_i2c_new_subdev_board i2c helper function

2009-06-06 Thread Eduardo Valentin
Hi Hans, On Sat, Jun 6, 2009 at 8:09 PM, Hans Verkuil wrote: > > On Saturday 06 June 2009 14:49:46 Hans Verkuil wrote: > > On Saturday 06 June 2009 13:59:19 Hans Verkuil wrote: > > > On Friday 29 May 2009 09:33:21 Eduardo Valentin wrote: > > > > # HG changeset patch > > > > # User Eduardo Valenti

Re: [PATCHv5 1 of 8] v4l2_subdev i2c: Add v4l2_i2c_new_subdev_board i2c helper function

2009-06-06 Thread Trent Piepho
On Sat, 6 Jun 2009, Andy Walls wrote: > +Alternatively, you can create the unsigned short array dynamically: > + > +struct v4l2_subdev *sd = v4l2_i2c_subdev(v4l2_dev, adapter, > +"module_foo", "chipid", 0, V4L2_I2C_ADDRS(0x10, 0x12)); > > Strictly speaking, that's not "dynamically" in t

Re: [PATCHv5 1 of 8] v4l2_subdev i2c: Add v4l2_i2c_new_subdev_board i2c helper function

2009-06-06 Thread Trent Piepho
On Sat, 6 Jun 2009, Hans Verkuil wrote: > On Saturday 06 June 2009 13:59:19 Hans Verkuil wrote: > > I propose to change the API as follows: > > > > #define V4L2_I2C_ADDRS(addr, addrs...) \ > > ((const unsigned short []){ addr, ## addrs, I2C_CLIENT_END }) > > > > struct v4l2_subdev *v4l2_i2c_new

Re: [PATCHv5 1 of 8] v4l2_subdev i2c: Add v4l2_i2c_new_subdev_board i2c helper function

2009-06-06 Thread Hans Verkuil
On Saturday 06 June 2009 14:49:46 Hans Verkuil wrote: > On Saturday 06 June 2009 13:59:19 Hans Verkuil wrote: > > On Friday 29 May 2009 09:33:21 Eduardo Valentin wrote: > > > # HG changeset patch > > > # User Eduardo Valentin > > > # Date 1243414605 -10800 > > > # Branch export > > > # Node ID 4fb

Re: [PATCHv5 1 of 8] v4l2_subdev i2c: Add v4l2_i2c_new_subdev_board i2c helper function

2009-06-06 Thread Hans Verkuil
On Saturday 06 June 2009 17:19:08 Andy Walls wrote: > On Sat, 2009-06-06 at 14:49 +0200, Hans Verkuil wrote: > > > I propose to change the API as follows: > > > > > > #define V4L2_I2C_ADDRS(addr, addrs...) \ > > > ((const unsigned short []){ addr, ## addrs, I2C_CLIENT_END }) > > > > > > Comments?

Re: [PATCHv5 1 of 8] v4l2_subdev i2c: Add v4l2_i2c_new_subdev_board i2c helper function

2009-06-06 Thread Andy Walls
On Sat, 2009-06-06 at 14:49 +0200, Hans Verkuil wrote: > > I propose to change the API as follows: > > > > #define V4L2_I2C_ADDRS(addr, addrs...) \ > > ((const unsigned short []){ addr, ## addrs, I2C_CLIENT_END }) > > Comments? If we decide to go this way, then I need to know soon so that I >

Re: [PATCHv5 1 of 8] v4l2_subdev i2c: Add v4l2_i2c_new_subdev_board i2c helper function

2009-06-06 Thread Hans Verkuil
On Saturday 06 June 2009 13:59:19 Hans Verkuil wrote: > On Friday 29 May 2009 09:33:21 Eduardo Valentin wrote: > > # HG changeset patch > > # User Eduardo Valentin > > # Date 1243414605 -10800 > > # Branch export > > # Node ID 4fb354645426f8b187c2c90cd8528b2518461005 > > # Parent 142fd6020df3b4d5

Re: [PATCHv5 1 of 8] v4l2_subdev i2c: Add v4l2_i2c_new_subdev_board i2c helper function

2009-06-06 Thread Hans Verkuil
On Friday 29 May 2009 09:33:21 Eduardo Valentin wrote: > # HG changeset patch > # User Eduardo Valentin > # Date 1243414605 -10800 > # Branch export > # Node ID 4fb354645426f8b187c2c90cd8528b2518461005 > # Parent 142fd6020df3b4d543068155e49a2618140efa49 > Device drivers of v4l2_subdev devices may

[PATCHv5 1 of 8] v4l2_subdev i2c: Add v4l2_i2c_new_subdev_board i2c helper function

2009-05-29 Thread Eduardo Valentin
# HG changeset patch # User Eduardo Valentin # Date 1243414605 -10800 # Branch export # Node ID 4fb354645426f8b187c2c90cd8528b2518461005 # Parent 142fd6020df3b4d543068155e49a2618140efa49 Device drivers of v4l2_subdev devices may want to have board specific data. This patch adds an helper function