Re: [PATCHv5 01/12] media: add 'index' to struct media_v2_pad

2018-08-03 Thread Mauro Carvalho Chehab
Em Fri, 3 Aug 2018 15:34:26 +0300 Sakari Ailus escreveu: > > Still thinking out loud, the fact that we can't change the size of the > > structures pointed to by media_v2_topology bothers me. We could add a > > version > > field to media_v2_topology that would be set by applications to tell the

Re: [PATCHv5 01/12] media: add 'index' to struct media_v2_pad

2018-08-03 Thread Sakari Ailus
Hi Laurent, On Wed, Jul 11, 2018 at 02:33:47PM +0300, Laurent Pinchart wrote: > Hi Hans, > > On Monday, 9 July 2018 16:40:51 EEST Hans Verkuil wrote: > > On 09/07/18 14:55, Laurent Pinchart wrote: > > > On Friday, 29 June 2018 14:43:20 EEST Hans Verkuil wrote: > > >> From: Hans Verkuil > > >> >

Re: [PATCHv5 01/12] media: add 'index' to struct media_v2_pad

2018-07-11 Thread Hans Verkuil
On 11/07/18 13:33, Laurent Pinchart wrote: > Hi Hans, > > On Monday, 9 July 2018 16:40:51 EEST Hans Verkuil wrote: >> On 09/07/18 14:55, Laurent Pinchart wrote: >>> On Friday, 29 June 2018 14:43:20 EEST Hans Verkuil wrote: From: Hans Verkuil The v2 pad structure never exposed the p

Re: [PATCHv5 01/12] media: add 'index' to struct media_v2_pad

2018-07-11 Thread Laurent Pinchart
Hi Hans, On Monday, 9 July 2018 16:40:51 EEST Hans Verkuil wrote: > On 09/07/18 14:55, Laurent Pinchart wrote: > > On Friday, 29 June 2018 14:43:20 EEST Hans Verkuil wrote: > >> From: Hans Verkuil > >> > >> The v2 pad structure never exposed the pad index, which made it > >> impossible > >> to c

Re: [PATCHv5 01/12] media: add 'index' to struct media_v2_pad

2018-07-09 Thread Hans Verkuil
On 09/07/18 14:55, Laurent Pinchart wrote: > Hi Hans, > > Thank you for the patch. > > On Friday, 29 June 2018 14:43:20 EEST Hans Verkuil wrote: >> From: Hans Verkuil >> >> The v2 pad structure never exposed the pad index, which made it impossible >> to call the MEDIA_IOC_SETUP_LINK ioctl, which

Re: [PATCHv5 01/12] media: add 'index' to struct media_v2_pad

2018-07-09 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Friday, 29 June 2018 14:43:20 EEST Hans Verkuil wrote: > From: Hans Verkuil > > The v2 pad structure never exposed the pad index, which made it impossible > to call the MEDIA_IOC_SETUP_LINK ioctl, which needs that information. > > It is really trivial to ju

[PATCHv5 01/12] media: add 'index' to struct media_v2_pad

2018-06-29 Thread Hans Verkuil
From: Hans Verkuil The v2 pad structure never exposed the pad index, which made it impossible to call the MEDIA_IOC_SETUP_LINK ioctl, which needs that information. It is really trivial to just expose this information, so implement this. Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus ---