Re: [PATCHv2 7/7] [PATCHv5] media: adv7180: fix field type

2016-08-03 Thread Niklas Söderlund
On 2016-08-03 10:14:45 -0700, Steve Longerbeam wrote: > On 08/03/2016 09:58 AM, Lars-Peter Clausen wrote: > > On 08/03/2016 06:55 PM, Steve Longerbeam wrote: > >> On 08/03/2016 06:21 AM, Niklas Söderlund wrote: > >>> On 2016-08-02 17:00:07 +0200, Lars-Peter Clausen wrote: > [...] > > diff

Re: [PATCHv2 7/7] [PATCHv5] media: adv7180: fix field type

2016-08-03 Thread Steve Longerbeam
On 08/03/2016 06:21 AM, Niklas Söderlund wrote: > On 2016-08-02 17:00:07 +0200, Lars-Peter Clausen wrote: >> [...] >>> diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c >>> index a8b434b..c6fed71 100644 >>> --- a/drivers/media/i2c/adv7180.c >>> +++ b/drivers/media/i2c/adv7180.c

Re: [PATCHv2 7/7] [PATCHv5] media: adv7180: fix field type

2016-08-03 Thread Steve Longerbeam
On 08/03/2016 09:58 AM, Lars-Peter Clausen wrote: > On 08/03/2016 06:55 PM, Steve Longerbeam wrote: >> On 08/03/2016 06:21 AM, Niklas Söderlund wrote: >>> On 2016-08-02 17:00:07 +0200, Lars-Peter Clausen wrote: [...] > diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c

Re: [PATCHv2 7/7] [PATCHv5] media: adv7180: fix field type

2016-08-03 Thread Lars-Peter Clausen
On 08/03/2016 06:55 PM, Steve Longerbeam wrote: > On 08/03/2016 06:21 AM, Niklas Söderlund wrote: >> On 2016-08-02 17:00:07 +0200, Lars-Peter Clausen wrote: >>> [...] diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c index a8b434b..c6fed71 100644 --- a/drivers/me

Re: [PATCHv2 7/7] [PATCHv5] media: adv7180: fix field type

2016-08-03 Thread Lars-Peter Clausen
On 08/03/2016 04:42 PM, Ian Arkver wrote: > On 03/08/16 15:23, Lars-Peter Clausen wrote: >> On 08/03/2016 04:11 PM, Hans Verkuil wrote: >>> >>> On 08/03/2016 03:21 PM, Niklas Söderlund wrote: On 2016-08-02 17:00:07 +0200, Lars-Peter Clausen wrote: > [...] >> diff --git a/drivers/media/

Re: [PATCHv2 7/7] [PATCHv5] media: adv7180: fix field type

2016-08-03 Thread Hans Verkuil
On 08/03/2016 04:42 PM, Ian Arkver wrote: > On 03/08/16 15:23, Lars-Peter Clausen wrote: >> On 08/03/2016 04:11 PM, Hans Verkuil wrote: >>> >>> On 08/03/2016 03:21 PM, Niklas Söderlund wrote: On 2016-08-02 17:00:07 +0200, Lars-Peter Clausen wrote: > [...] >> diff --git a/drivers/medi

Re: [PATCHv2 7/7] [PATCHv5] media: adv7180: fix field type

2016-08-03 Thread Ian Arkver
On 03/08/16 15:23, Lars-Peter Clausen wrote: On 08/03/2016 04:11 PM, Hans Verkuil wrote: On 08/03/2016 03:21 PM, Niklas Söderlund wrote: On 2016-08-02 17:00:07 +0200, Lars-Peter Clausen wrote: [...] diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c index a8b434b..c6fed71

Re: [PATCHv2 7/7] [PATCHv5] media: adv7180: fix field type

2016-08-03 Thread Lars-Peter Clausen
On 08/03/2016 04:11 PM, Hans Verkuil wrote: > > > On 08/03/2016 03:21 PM, Niklas Söderlund wrote: >> On 2016-08-02 17:00:07 +0200, Lars-Peter Clausen wrote: >>> [...] diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c index a8b434b..c6fed71 100644 --- a/drivers/

Re: [PATCHv2 7/7] [PATCHv5] media: adv7180: fix field type

2016-08-03 Thread Hans Verkuil
On 08/03/2016 04:23 PM, Lars-Peter Clausen wrote: > On 08/03/2016 04:11 PM, Hans Verkuil wrote: >> >> >> On 08/03/2016 03:21 PM, Niklas Söderlund wrote: >>> On 2016-08-02 17:00:07 +0200, Lars-Peter Clausen wrote: [...] > diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv718

Re: [PATCHv2 7/7] [PATCHv5] media: adv7180: fix field type

2016-08-03 Thread Lars-Peter Clausen
On 08/03/2016 04:23 PM, Lars-Peter Clausen wrote: > On 08/03/2016 04:11 PM, Hans Verkuil wrote: >> >> >> On 08/03/2016 03:21 PM, Niklas Söderlund wrote: >>> On 2016-08-02 17:00:07 +0200, Lars-Peter Clausen wrote: [...] > diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.

Re: [PATCHv2 7/7] [PATCHv5] media: adv7180: fix field type

2016-08-03 Thread Hans Verkuil
On 08/03/2016 03:21 PM, Niklas Söderlund wrote: > On 2016-08-02 17:00:07 +0200, Lars-Peter Clausen wrote: >> [...] >>> diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c >>> index a8b434b..c6fed71 100644 >>> --- a/drivers/media/i2c/adv7180.c >>> +++ b/drivers/media/i2c/adv7180

Re: [PATCHv2 7/7] [PATCHv5] media: adv7180: fix field type

2016-08-03 Thread Niklas Söderlund
On 2016-08-02 17:00:07 +0200, Lars-Peter Clausen wrote: > [...] > > diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c > > index a8b434b..c6fed71 100644 > > --- a/drivers/media/i2c/adv7180.c > > +++ b/drivers/media/i2c/adv7180.c > > @@ -680,10 +680,13 @@ static int adv7180_set_p

Re: [PATCHv2 7/7] [PATCHv5] media: adv7180: fix field type

2016-08-02 Thread Lars-Peter Clausen
[...] > diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c > index a8b434b..c6fed71 100644 > --- a/drivers/media/i2c/adv7180.c > +++ b/drivers/media/i2c/adv7180.c > @@ -680,10 +680,13 @@ static int adv7180_set_pad_format(struct v4l2_subdev > *sd, > switch (format->format.

[PATCHv2 7/7] [PATCHv5] media: adv7180: fix field type

2016-08-02 Thread Niklas Söderlund
From: Steve Longerbeam The ADV7180 and ADV7182 transmit whole fields, bottom field followed by top (or vice-versa, depending on detected video standard). So for chips that do not have support for explicitly setting the field mode, set the field mode to V4L2_FIELD_ALTERNATE. Signed-off-by: Steve