Re: [PATCHv1 29/38] marvell-ccic: check register address.

2013-06-04 Thread Jonathan Corbet
On Wed, 29 May 2013 13:00:02 +0200 Hans Verkuil wrote: > From: Hans Verkuil > > Prevent out-of-range register accesses. Certainly I agree with the goal, and what's here is better than what the driver does now. But... > + if (reg->reg > cam->regs_size - 4) > + return -EINVAL;

[PATCHv1 29/38] marvell-ccic: check register address.

2013-05-29 Thread Hans Verkuil
From: Hans Verkuil Prevent out-of-range register accesses. Signed-off-by: Hans Verkuil Cc: Jonathan Corbet --- drivers/media/platform/marvell-ccic/cafe-driver.c |1 + drivers/media/platform/marvell-ccic/mcam-core.c |4 drivers/media/platform/marvell-ccic/mcam-core.h |1 +