Re: [Outreachy kernel] [PATCH vicodec] media: pvrusb2: replace `printk` with `pr_*`

2018-10-08 Thread Greg KH
On Mon, Oct 08, 2018 at 03:29:03PM +0200, Hans Verkuil wrote: > On 10/08/2018 03:07 PM, Greg KH wrote: > > On Mon, Oct 08, 2018 at 03:06:47PM +0300, Dafna Hirschfeld wrote: > >> Replace calls to `printk` with the appropriate `pr_*` > >> macro. > >> > >> Signed-off-by: Dafna Hirschfeld > >> --- > >

Re: [Outreachy kernel] [PATCH vicodec] media: pvrusb2: replace `printk` with `pr_*`

2018-10-08 Thread Hans Verkuil
On 10/08/2018 03:07 PM, Greg KH wrote: > On Mon, Oct 08, 2018 at 03:06:47PM +0300, Dafna Hirschfeld wrote: >> Replace calls to `printk` with the appropriate `pr_*` >> macro. >> >> Signed-off-by: Dafna Hirschfeld >> --- >> drivers/media/usb/pvrusb2/pvrusb2-debug.h| 2 +- >> drivers/media/usb/

Re: [Outreachy kernel] [PATCH vicodec] media: pvrusb2: replace `printk` with `pr_*`

2018-10-08 Thread Greg KH
On Mon, Oct 08, 2018 at 03:06:47PM +0300, Dafna Hirschfeld wrote: > Replace calls to `printk` with the appropriate `pr_*` > macro. > > Signed-off-by: Dafna Hirschfeld > --- > drivers/media/usb/pvrusb2/pvrusb2-debug.h| 2 +- > drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 8 +++--- > drive

[PATCH vicodec] media: pvrusb2: replace `printk` with `pr_*`

2018-10-08 Thread Dafna Hirschfeld
Replace calls to `printk` with the appropriate `pr_*` macro. Signed-off-by: Dafna Hirschfeld --- drivers/media/usb/pvrusb2/pvrusb2-debug.h| 2 +- drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 8 +++--- drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c | 28 +--- drivers/media/u

Re: [PATCH vicodec] media: pvrusb2: replace `printk` with `pr_*`

2018-10-07 Thread Helen Koike
Hi Dafna, Thanks for you patch. On 10/6/18 4:21 PM, Dafna Hirschfeld wrote: > Replace calls to `printk` with the appropriate `pr_*` > macro. > > Signed-off-by: Dafna Hirschfeld > --- > drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 8 > drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c |

Re: [Outreachy kernel] [PATCH vicodec] media: pvrusb2: replace `printk` with `pr_*`

2018-10-07 Thread Hans Verkuil
On 10/07/2018 01:03 AM, Sasha Levin wrote: > On Sat, Oct 06, 2018 at 10:21:38PM +0300, Dafna Hirschfeld wrote: >> Replace calls to `printk` with the appropriate `pr_*` >> macro. > > Hi Dafna, > > I'd encourage you to look into the dev_ family of print functions (such > as dev_info() ). They can a

Re: [Outreachy kernel] [PATCH vicodec] media: pvrusb2: replace `printk` with `pr_*`

2018-10-06 Thread Sasha Levin
On Sat, Oct 06, 2018 at 10:21:38PM +0300, Dafna Hirschfeld wrote: Replace calls to `printk` with the appropriate `pr_*` macro. Hi Dafna, I'd encourage you to look into the dev_ family of print functions (such as dev_info() ). They can avoid having to repeat the driver name in every print call.

[PATCH vicodec] media: pvrusb2: replace `printk` with `pr_*`

2018-10-06 Thread Dafna Hirschfeld
Replace calls to `printk` with the appropriate `pr_*` macro. Signed-off-by: Dafna Hirschfeld --- drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 8 drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c | 14 ++ drivers/media/usb/pvrusb2/pvrusb2-main.c | 4 ++-- drivers/media/usb